1005089 - crash in mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<mozilla::dom::EventTarget>, true>::Wrap(JSContext*, nsRefPtr<mozilla::dom::EventTarget> const&, JS::MutableHandle<JS::Value>)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-401a6439-5547-4749-b520-15b202140501.
=============================================================

Comment 1

[Boris Zbarsky [:bzbarsky]]

Olli, Touch.webidl lists "target" as not nullable.  This crash shows it seems to be null sometimes?  Is that expected?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

It shouldn't be.

Is this a regression?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

But I can see a case... if there is some native anonymous content

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: branch safe patch

Thinking about other approaches for trunk, but this should be fine for branches.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8416707 [details] [diff] [review]
branch safe patch

r=me

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Commit message "Bug 1005089, let touch.target be null, r=bz"

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79686836f1f7

Comment 8

[Carsten Book [:Tomcat]]

sorry had to backout this change for bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=39037844&tree=Mozilla-Inbound

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Target() -> GetTarget()

Apparently I had managed to not re-compile everything.
https://hg.mozilla.org/integration/mozilla-inbound/rev/74d7fb43bb44

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/74d7fb43bb44