Closed Bug 1005105 Opened 6 years ago Closed 5 years ago
Tab background color doesn't match toolbar color in Firefox 29 (need to remove the noise texture)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release) Build ID: 20140421221237 Steps to reproduce: Look at the background of the active tab vs. the background of the toolbar. Actual results: The background colors don't match. There's a distinct boundary line between the tab and the toolbar. The difference is more noticeable on some displays. Expected results: The background colors should be the same.
The color varies pixel to pixel but the tab color hovers around RGB 239/245/251 and the toolbar color is around 231/241/251.
(1) I actually, honestly, can't see a difference between the tab and the toolbar in your screenshot (2) This was filed already but I can't find the dupe right now, so marking as DUPEME... Stephen, can you look into this?
Component: Untriaged → Theme
It is slightly off in the screenshot, probably has something to do with the tab stroke overlay. But I am not noticing it locally…
I can easily see a mismatch in the screenshot and locally if I look at my display from a suboptimal angle.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Tab background color doesn't match toolbar color in Firefox 29 → Tab background color doesn't match toolbar color in Firefox 29 (need to remove the noise texture)
Stephen could you please provide the needed images with the noise removed? I believe this is the complete list: tab-active-middle.png email@example.com tab-background-end.png firstname.lastname@example.org tab-background-middle.png email@example.com tab-background-start.png firstname.lastname@example.org tab-stroke-end.png email@example.com tab-stroke-start.png firstname.lastname@example.org We'll also want to copy the updated images over to browser/themes/linux/tabbrowser/, except for the @2x variants.
(In reply to Dão Gottwald [:dao] from comment #7) > Stephen could you please provide the needed images with the noise removed? I > believe this is the complete list: or mmaslaney...
I exported new images and made sure they do not have any kind of background or noise on them. But I am still getting weird artifacts or dithering on the tabs. Can someone else verify this please? It might have nothing to do with the images and instead something to do with the way the tabs are constructed?
Comment on attachment 8575986 [details] [diff] [review] remove-tab-noise.patch - 01 This surely looks like a definite improvement to me. I'll attach a before/after screenshot with a filter applied to make the noise and the lack thereof more visible.
Attachment #8575986 - Flags: feedback+
Also using the new textures on Linux.
Status: NEW → ASSIGNED
Iteration: --- → 39.2 - 23 Mar
Points: --- → 2
Comment on attachment 8576024 [details] [diff] [review] patch Review of attachment 8576024 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8576024 - Flags: review?(jaws) → review+
This looks like a very low visibility/impact UI issue, not really worth the effort for manual testing.
Flags: qe-verify+ → qe-verify-
Depends on: 1143057
I was just wondering why was the OS set to windows 7 , where I can see an attachment from linux
(In reply to Towkir Ahmed [:Towkir] from comment #20) > I was just wondering why was the OS set to windows 7 , where I can see an > attachment from linux The screenshots are from Windows, but one has had the contrast modified.
You need to log in before you can comment on or make changes to this bug.