Closed Bug 1005184 Opened 6 years ago Closed 3 years ago

NeckoParent should handle ActorDestroy

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jaas, Assigned: jduell.mcbugs)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → jduell.mcbugs
Whiteboard: [necko-active]
Turns out this is a non-issue.  

As :billm tells me:

"By itself, ActorDestroy isn't too important for sub-protocols that are entirely managed by IPDL (meaning they're deleted inside DeallocPFoo). The destructor will be invoked pretty shortly (i.e., same turn of the event loop) after ActorDestroy is called, so you're not missing much by ignoring ActorDestroy."
Remove "To fix" comments in code and replace with explanation why we have nothing to fix here.
Attachment #8784181 - Flags: review+
This time with the actual patch :)
Attachment #8784181 - Attachment is obsolete: true
Attachment #8784182 - Flags: review+
Keywords: checkin-needed
Please use commit messages that explain what the patch is doing. The one for the attached patch is completely non-informative.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4da60cb24006
Clarify comments in Necko ActorDestroy functions clarifying that nothing needs to be implemented. r=jduell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4da60cb24006
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.