Closed Bug 1005298 Opened 6 years ago Closed 6 years ago

Add "layout.display-list.dump" Preference

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Right now display list dumps are enabled via an environment variable. This is not ideal for mobile.
Attachment #8416696 - Flags: review?(matt.woodrow)
Attached patch patch (obsolete) — Splinter Review
Removed unrelated hunk
Assignee: nobody → bgirard
Attachment #8416696 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8416696 - Flags: review?(matt.woodrow)
Comment on attachment 8416698 [details] [diff] [review]
patch

Review of attachment 8416698 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +1076,5 @@
>    gfxUtils::CopyAsDataURL(dt.get());
>  }
>  
> +/* static */ bool
> +gfxUtils::sDumpPaintList() {

Drop the 's' prefix from the function name.

Can you check if you can still set the value of sEnvValue easily from a debugger? If you can't I'd prefer if you left the sDumpPaintList variable outside of the function so that you can.

I generally pref flipping paint list dumping on/off from lldb, so don't want to regress that.
Attachment #8416698 - Flags: review+
Attachment #8416698 - Attachment is obsolete: true
(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Can you check if you can still set the value of sEnvValue easily from a
> debugger? If you can't I'd prefer if you left the sDumpPaintList variable
> outside of the function so that you can.

I just switched it. Maybe it works with some debugger but it's unlikely to work well across platforms.
https://hg.mozilla.org/mozilla-central/rev/d572fe88d3eb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.