Closed Bug 1005495 Opened 6 years ago Closed 6 years ago

Move sccache stats out of the build log

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Currently, sccache stats are inline in the build log, which is inconvenient and makes the logs bigger. Let's move them in a separate file that we upload during make upload.
Attachment #8416912 - Flags: review?(mshal)
Comment on attachment 8416912 [details] [diff] [review]
Move sccache stats out of the build log

>+ifdef OBJDIR
>+BASE_DIR = $(OBJDIR)
>+else
>+BASE_DIR = $(MOZ_OBJDIR)/$(firstword $(MOZ_BUILD_PROJECTS))
>+endif

Can you add a comment for this block? I'm guessing it's needed because we can only upload files from $(DIST), but for multi-project builds we need to just pick one of the DIST directories to stick sccache.log.gz so it can be uploaded from that project (and ignored for the other projects, since all stats go in the same log file).
Attachment #8416912 - Flags: review?(mshal) → review+
Depends on: 1007010
https://hg.mozilla.org/mozilla-central/rev/41708cef5ec1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 1008015
Blocks: 1009359
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.