Closed Bug 1005511 Opened 10 years ago Closed 10 years ago

JSHint fixes for shared/js/device_storage/

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S2 (23may)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=2],[systemsfe])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
djf
: review+
julienw
: feedback+
Details | Review 
We would like to have these files in this folder passing JSHint. Anyone is free to take this bug if it is unassigned.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [p=2],[systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8420704 [details] [review]
Github pull request

David - this is pretty low priority, but if you get a chance to review it, it would be appreciated. Thanks!

        Attachment #8420704 -
        Flags: review?(dflanagan)

    
    

    
  
Comment on attachment 8420704 [details] [review]
Github pull request

Or Julien - maybe you could take a look? Thanks!

        Attachment #8420704 -
        Flags: review?(felash)

    
    

    
  
Comment on attachment 8420704 [details] [review]
Github pull request

lgtm but I'd rather wait for a review from David.

        Attachment #8420704 -
        Flags: review?(felash) → feedback+

    
    

    
  
Hey David, can you please have a quick look at this? This looks good from my point of view but I'd be more comfortable if you review this as well (not because it's complicated, rather just so that you know it's happening).

THis should really not take too much time!
Flags: needinfo?(dflanagan)

    
    

    
  
Comment on attachment 8420704 [details] [review]
Github pull request

r+, but I've got one nit noted on github: you moved an onerror handler without moving the onsuccess handler that is paired with.  I'd prefer it if you'd keep them together.

        Attachment #8420704 -
        Flags: review?(dflanagan) → review+
Flags: needinfo?(dflanagan)

    
    

    
  
Update the PR. It just had be moved due to being defined after it's used and JSHint doens't like that.

Landed: https://github.com/mozilla-b2g/gaia/commit/168ab69379c8cf874f700ed914e86c685426a6df
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: