1005580 - "Assertion failure: fragment" with </frameset> and other junk after </html>

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Jesse Ruderman]

Attachment: a.html

This testcase is slightly more complicated than the fixed one in bug 822776.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Ruderman]

Assertion failure: fragment, at parser/html/nsHtml5TreeBuilder.cpp:2882

Comment 3

[William Chen [:wchen]]

Attachment: Fix after after frameset insertion mode in HTML parser for handling characters.

Same issue as bug 822776, except for handing the character case.

This patch updates the behavior to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#the-after-after-frameset-insertion-mode

Also replaced some unused value assignments with comments.

Comment 4

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0523fcc5af9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0523fcc5af9

Comment 6

[Paul Silaghi, QA [:pauly]]

Simply opening a new empty tab beside the tab with the testcase results in:
[Child 8572] ###!!! ASSERTION: nsSSLStatus has null mServerCert or was called in the content process
: 'Error', file c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\security\manager\ssl\src\n
sSSLStatus.cpp, line 112

Thoughts?

Comment 7

[William Chen [:wchen]]

I am not able to reproduce that. Is this reproducible for you? Does this only happen when you open a new tab beside the testcase? Does this only happen after the fix?.

Looking at the code, I strongly suspect that this bug and the assertion in nsSSLStatus.cpp are different issues. I'll investigate this further if there is some evidence that the two are related.

Comment 8

[Paul Silaghi, QA [:pauly]]

Actually it's not related. It happens before/after the fix by simply opening a new tab (without having the testcase open). Probably bug 900515.
Marking this bug verified fixed on Nightly 32.0a1 2014-05-08-mozilla-central-debug, Win 7 x64.