test_getBoxQuads_convertPointRectQuad.html will be permaorange when 32 merges to beta on July 21st

RESOLVED FIXED in Firefox 32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philor, Assigned: roc)

Tracking

Trunk
mozilla32
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox29 unaffected, firefox30 unaffected, firefox31+ disabled, firefox32+ fixed, firefox-esr24 unaffected, b2g30 unaffected)

Details

(Whiteboard: [qa-] )

Attachments

(1 attachment)

Bug 917755 made support for getBoxQuads ifndef RELEASE_BUILD, but left test_getBoxQuads_convertPointRectQuad.html running in release builds, so as the mochitest-4s in https://tbpl.mozilla.org/?tree=Try&rev=f8298a1f2d72 say, when current-aurora merges to beta, it's going to start failing.
Halfway there.
Disabled the test for 31 in https://hg.mozilla.org/releases/mozilla-aurora/rev/745d64845c17 since I don't know whether I'll be around next weekend to disable it after another week of inaction.
And I absolutely won't be around for the July 21st merge, when 32 will be permaorange, so someone needs to do something by then.
Summary: test_getBoxQuads_convertPointRectQuad.html will be permaorange when 31 merges to beta on June 9th → test_getBoxQuads_convertPointRectQuad.html will be permaorange when 32 merges to beta on July 21st
Whiteboard: [qa-]
The test has
  SpecialPowers.pushPrefEnv({"set": [["layout.css.DOMPoint.enabled", true],
                                     ["layout.css.DOMQuad.enabled", true],
                                     ["layout.css.getBoxQuads.enabled", true],
                                     ["layout.css.convertFromNode.enabled", true]]}, runTest);
so what's the problem?
Flags: needinfo?(roc) → needinfo?(philringnalda)
It... needs some other pref set? It... relies on some other ifdeffed code, not just ifdeffed prefs, like maybe that whatever-it-is webidl that something somethings with or about layout.css.DOMQuad.enabled in http://mxr.mozilla.org/mozilla-central/source/dom/webidl/DOMQuad.webidl#13? pushPrefEnv doesn't actually work?

If I knew, I would have fixed it rather than disabling it.
Flags: needinfo?(philringnalda) → needinfo?(roc)
Posted patch fixSplinter Review
Assignee: nobody → roc
Attachment #8432934 - Flags: review?(matspal)
Flags: needinfo?(roc)
I needed an aurora-as-beta push anyway, so, try: https://tbpl.mozilla.org/?tree=Try&rev=3d4d143e5db0
Comment on attachment 8432934 [details] [diff] [review]
fix

r=mats
Attachment #8432934 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/74f132824fda
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.