Closed
Bug 1005588
Opened 11 years ago
Closed 11 years ago
test_getBoxQuads_convertPointRectQuad.html will be permaorange when 32 merges to beta on July 21st
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla32
Tracking | Status | |
---|---|---|
firefox29 | --- | unaffected |
firefox30 | --- | unaffected |
firefox31 | + | disabled |
firefox32 | + | fixed |
firefox-esr24 | --- | unaffected |
b2g30 | --- | unaffected |
People
(Reporter: philor, Assigned: roc)
References
Details
(Whiteboard: [qa-] )
Attachments
(1 file)
3.02 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Bug 917755 made support for getBoxQuads ifndef RELEASE_BUILD, but left test_getBoxQuads_convertPointRectQuad.html running in release builds, so as the mochitest-4s in https://tbpl.mozilla.org/?tree=Try&rev=f8298a1f2d72 say, when current-aurora merges to beta, it's going to start failing.
Updated•11 years ago
|
Reporter | ||
Comment 2•11 years ago
|
||
Disabled the test for 31 in https://hg.mozilla.org/releases/mozilla-aurora/rev/745d64845c17 since I don't know whether I'll be around next weekend to disable it after another week of inaction.
Reporter | ||
Comment 3•11 years ago
|
||
And I absolutely won't be around for the July 21st merge, when 32 will be permaorange, so someone needs to do something by then.
tracking-firefox32:
--- → ?
Summary: test_getBoxQuads_convertPointRectQuad.html will be permaorange when 31 merges to beta on June 9th → test_getBoxQuads_convertPointRectQuad.html will be permaorange when 32 merges to beta on July 21st
Flags: needinfo?(roc)
Updated•11 years ago
|
Whiteboard: [qa-]
Assignee | ||
Comment 4•11 years ago
|
||
The test has
SpecialPowers.pushPrefEnv({"set": [["layout.css.DOMPoint.enabled", true],
["layout.css.DOMQuad.enabled", true],
["layout.css.getBoxQuads.enabled", true],
["layout.css.convertFromNode.enabled", true]]}, runTest);
so what's the problem?
Flags: needinfo?(roc) → needinfo?(philringnalda)
Reporter | ||
Comment 5•11 years ago
|
||
It... needs some other pref set? It... relies on some other ifdeffed code, not just ifdeffed prefs, like maybe that whatever-it-is webidl that something somethings with or about layout.css.DOMQuad.enabled in http://mxr.mozilla.org/mozilla-central/source/dom/webidl/DOMQuad.webidl#13? pushPrefEnv doesn't actually work?
If I knew, I would have fixed it rather than disabling it.
Flags: needinfo?(philringnalda) → needinfo?(roc)
Assignee | ||
Comment 6•11 years ago
|
||
Reporter | ||
Comment 7•11 years ago
|
||
I needed an aurora-as-beta push anyway, so, try: https://tbpl.mozilla.org/?tree=Try&rev=3d4d143e5db0
Updated•11 years ago
|
Comment 8•11 years ago
|
||
Comment on attachment 8432934 [details] [diff] [review]
fix
r=mats
Attachment #8432934 -
Flags: review?(matspal) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•