1005613 - Validate existing BMO/Bugzilla e-mail addresses in profiles

Status: VERIFIED WONTFIX

(Participation Infrastructure :: Phonebook, defect)

Description

[[:Aleksej]]

Probably due to bug 711558 or my workaround for it, I had "%2B" instead of the "+" in my e-mail address.  Today the bmo profile link didn't work because of it, until I replaced that with "+" in my profile.  It also may have caused my bug 1000000 guess to be discarded.

There are probably other profiles with invalid BMO addresses, due to that, or typos, or asynchronous changes.  I suggest that account links in the profiles are validated — now, periodically, or when updating the profile.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Aleksej,

You say that your email address in mozillians, the one you use to log-in, contains the character +. I visit your profile page and this is not the case. Did you change your email address?

The email address you use to log-in has nothing to do with your bugzilla identifier, filled under the "External Accounts" section. There you indeed have an email address that contains character + but it's displayed correctly and the link actually links to your bugzilla profile. 

I don't understand the problem here. Please help me understand it so we can fix it :)

Comment 2

[[:Aleksej]]

(In reply to [:Aleksej] from comment #0)
> It also may have caused my bug 1000000 guess to be discarded.

Gerv said addresses were not processed automatically.

(In reply to Giorgos Logiotatidis [:giorgos] from comment #1)
> Aleksej,
> 
> You say that your email address in mozillians, the one you use to log-in,
> contains the character +.

The BMO address in my profile, not the Mozillians login address.

> identifier, filled under the "External Accounts" section. There you indeed
> have an email address that contains character + but it's displayed correctly
> and the link actually links to your bugzilla profile. 

I changed the "%2B" to "+" before filing this bug.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

(In reply to [:Aleksej] from comment #2)> 
> (In reply to Giorgos Logiotatidis [:giorgos] from comment #1)
> > Aleksej,
> > 
> > You say that your email address in mozillians, the one you use to log-in,
> > contains the character +.
> 
> The BMO address in my profile, not the Mozillians login address.

OK so that has nothing to do with bug 711558, since it's not related to the login email address and/or browserid.

> 
> > identifier, filled under the "External Accounts" section. There you indeed
> > have an email address that contains character + but it's displayed correctly
> > and the link actually links to your bugzilla profile. 
> 
> I changed the "%2B" to "+" before filing this bug.

Therefore + is a valid character and you manually chose to use %2B instead of + in the first place. I do I understand something wrong here?

Comment 4

[[:Aleksej]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #3)
> Therefore + is a valid character and you manually chose to use %2B instead
> of + in the first place. I do I understand something wrong here?

Maybe it didn't work in the past.  I wouldn't have chosen %2B otherwise.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

Maybe there was a confusion with bug 711558 but the External Accounts code is pretty recent and we didn't have any issues with "special" characters. In any case I'm glad it works for you.

No regarding this bug, you suggest that we validate the addresses. Against what do you suggest that we validate the addresses?

Comment 6

[[:Aleksej]]

Against BMO?

But I had been assuming it was used for something, and hence for something else, too.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

So the identifier connecting BMO with mozillians is actually that email address, so if people do have that email address entered wrong in mozillians.org there is no way to automatically match them. 

Although it would be nice to have a more solid procedure to identify the external accounts that mozillians add to their profile, something like verify that the BMO address you put in is actually yours which would also prevent such errors, I believe that this is rather low priority now.

Given that + sign and other special characters work as expected, and I believe that this worked in External Accounts from the introduction of this feature, I suggest that we mark this is bug as WONTFIX.

Comment 8

[Justin Crawford [:hoosteeno] [:jcrawford]]

+1 to the suggestion in comment 7.

Comment 9

[[:Aleksej]]

OK then.

Comment 10

[Matt Brandt [:mbrandt]]

Bumping to verified per comment 9 -- thanks :Aleksej