Closed Bug 1005652 Opened 10 years ago Closed 10 years ago

Clang Static Analysis: Memory allocated by 'new' should be deallocated by 'delete', not free() r=bsmedberg

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: sblin, Assigned: sblin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

dom-minor-fix.diff
1.28 KB, patch
sblin
: review+
Details | Diff | Splinter Review
Attached patch dom-minor-fix.diff (obsolete) — — Splinter Review 
+++ This bug was initially created as a clone of Bug #1003975 +++

The attached patch fixes a warning detected by scan-build, the clang static analyzer.
Attachment #8417041 - Flags: review?(benjamin)
Attachment #8417041 - Flags: review?(benjamin) → review+
Attachment #8417041 - Flags: checkin?
Comment on attachment 8417041 [details] [diff] [review]
dom-minor-fix.diff

Please give this patch a more descriptive commit message below the guidelines below.
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Also, please use the checkin-needed bug keyword in the future :)
Attachment #8417041 - Flags: checkin?
Attached patch dom-minor-fix.diff (obsolete) — — Splinter Review 

        Attachment #8417041 -
        Attachment is obsolete: true

        Attachment #8418016 -
        Flags: review+

    
  
Keywords: checkin-needed

    
  
Summary: Clang Static Analysis: Memory allocated by 'new' should be deallocated by 'delete', not free() → Clang Static Analysis: Memory allocated by 'new' should be deallocated by 'delete', not free() r=bsmedberg

    
    

    
  


  

        Attachment #8418016 -
        Attachment is obsolete: true

        Attachment #8418017 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e436a3c3dcb3
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

    
  
Product: Core → Firefox Build System

    
  
Product: Firefox Build System → Developer Infrastructure

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: