1005667 - pkixtestutil.cpp:533:9: warning: logical not is only applied to the left hand side of this comparison [,-Wlogical-not-parentheses] (error in warnings-as-errors builds)

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning with clang 3.4, on mozilla-inbound, treated as error in builds with --enable-warnings-as-errors:
{
security/pkix/test/lib/pkixtestutil.cpp:533:9: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
     if (!output.Add(critical) != der::Success) {
         ^                     ~~
}

Do we really want to negate the result of "Add()" before we compare it to Success?  Looks like a bug.  If we do, we can put parens around the "!..." expression to silence the warning, I think.


This line just landed on inbound earlier today, in
 https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5624d51bd3
for bug 1005198.

Comment 1

[Daniel Holbert [:dholbert]]

Specifically, the line was added here:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5624d51bd3#l2.451

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: dholbert.patch

I marked this as r=dholbert since you identified the typo and the fix, and I just fixed the thing you told me to fix:

https://tbpl.mozilla.org/?tree=Mozilla-Inbound

Comment 3

[Daniel Holbert [:dholbert]]

Sounds good to me.  Thanks for the quick action!

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/25d1dbbba141