1005719 - [B2G][1.4][Settings] The string "Screen reader started" appears in English on all languages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: Screen reader started.png

Description:
The string "Screen reader started" appears in English on all languages.

Repro Steps:
1) Updated Buri to Build ID: 20140430000201
2) Change the language to "French".
3) Tap on the "Settings" app.
4) Tap on "Developer" and tap on "Show accessibility settings".
5) Back out and tap on "Accessibility".
6) Tap on the "Screen reader" toggle.
7) Tap on "Start" and observe the "Screen reader started" message.

Actual:
The string "Screen reader started" is not translated.

Expected:
The string is translated on all languages.

Environmental Variables
Device: Buri v 1.4.0 Mozilla RIL
Build ID: 20140430000201
Gecko: https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/123485e733d5
Gaia: 81e97c3ca58be0487292011bc59efa4cebab30be
Platform Version: 30.0
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 100%
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Does this happen on 1.3?

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

In 1.3 the option to enable Screen Reader is located in Developer menu, and when enabled, there is no message popping up saying that screen reader is enabled.

In short, this does NOT reproduce in 1.3 (because the message does not exist).

Tested on:
Device: Buri 1.3 MOZ
BuildID: 20140505024001
Gaia: 667539f1ed4becc45b182a5f1046221d3eeb9e7c
Gecko: bf3fe474bf50
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

Not a blocker mainly because accessibility settings will only be shown if the dev switch is flipped. However, we should get this fixed.

Yura - Can you add this to your backlog of items to fix?

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

It looks like the sting is localized in most languages (at least french as reported in the description):
http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/AccessFu.properties:screenReaderStarted&repo=aurora

It looks like m-c (and hence the gecko used in this build) only has en-US, the other locales are packaged differently and not present by default.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Yura Zenevich [:yzen] from comment #5)
> It looks like the sting is localized in most languages (at least french as
> reported in the description):
> http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/
> AccessFu.properties:screenReaderStarted&repo=aurora

I don't think that's enough to ensure that the string is localized in the product. The string needs to be referenced correctly in gaia code in order for it to be localized.

Comment 7

[Eitan Isaacson [:eeejay]]

(In reply to Jason Smith [:jsmith] from comment #6)
> (In reply to Yura Zenevich [:yzen] from comment #5)
> > It looks like the sting is localized in most languages (at least french as
> > reported in the description):
> > http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/
> > AccessFu.properties:screenReaderStarted&repo=aurora
> 
> I don't think that's enough to ensure that the string is localized in the
> product. The string needs to be referenced correctly in gaia code in order
> for it to be localized.

The origin of that string is chrome JS, it has nothing to do with gaia or any content. Pretty sure :)

Comment 8

[Jason Smith [:jsmith]]

(In reply to Eitan Isaacson [:eeejay] from comment #7)
> (In reply to Jason Smith [:jsmith] from comment #6)
> > (In reply to Yura Zenevich [:yzen] from comment #5)
> > > It looks like the sting is localized in most languages (at least french as
> > > reported in the description):
> > > http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/
> > > AccessFu.properties:screenReaderStarted&repo=aurora
> > 
> > I don't think that's enough to ensure that the string is localized in the
> > product. The string needs to be referenced correctly in gaia code in order
> > for it to be localized.
> 
> The origin of that string is chrome JS, it has nothing to do with gaia or
> any content. Pretty sure :)

Ok - so why is not localized then?

Comment 9

[Eitan Isaacson [:eeejay]]

(In reply to Jason Smith [:jsmith] from comment #8)
> (In reply to Eitan Isaacson [:eeejay] from comment #7)
> > (In reply to Jason Smith [:jsmith] from comment #6)
> > > (In reply to Yura Zenevich [:yzen] from comment #5)
> > > > It looks like the sting is localized in most languages (at least french as
> > > > reported in the description):
> > > > http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/
> > > > AccessFu.properties:screenReaderStarted&repo=aurora
> > > 
> > > I don't think that's enough to ensure that the string is localized in the
> > > product. The string needs to be referenced correctly in gaia code in order
> > > for it to be localized.
> > 
> > The origin of that string is chrome JS, it has nothing to do with gaia or
> > any content. Pretty sure :)
> 
> Ok - so why is not localized then?

Possibly because the gecko layer is not localized the same way it is on desktop/android? If that is the case, we will have other issues with the screen reader, since it will use en-US for internal strings regardless of the locale set in gaia.

Comment 10

[Théo Chevalier]

(In reply to Jason Smith [:jsmith] from comment #8)
> (In reply to Eitan Isaacson [:eeejay] from comment #7)
> > (In reply to Jason Smith [:jsmith] from comment #6)
> > > (In reply to Yura Zenevich [:yzen] from comment #5)
> > > > It looks like the sting is localized in most languages (at least french as
> > > > reported in the description):
> > > > http://transvision.mozfr.org/string/?entity=dom/chrome/accessibility/
> > > > AccessFu.properties:screenReaderStarted&repo=aurora
> > > 
> > > I don't think that's enough to ensure that the string is localized in the
> > > product. The string needs to be referenced correctly in gaia code in order
> > > for it to be localized.
> > 
> > The origin of that string is chrome JS, it has nothing to do with gaia or
> > any content. Pretty sure :)
> 
> Ok - so why is not localized then?

I confirm, it's not under https://hg.mozilla.org/gaia-l10n/en-US ? Then it's not localized.

Comment 11

[Francesco Lodolo [:flod]]

I don't think this bug is actually late-l10n at this point, since it requires a lot more work (we need those strings in Gaia, we don't localize Gecko at the moment).

Comment 12

[Francesco Lodolo [:flod]]

Removing keyword for now.

Comment 13

[[e-mail]]

Is this issue resolved?

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

This is not an issue any more. Now if screen reader is enabled, a user is only able to select a language compatible with the screen reader.