1005730 - Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[(no longer active)]

The hyphenation changes are necessary because hnjalloc.h #defines FILE to
a custom data structure, which clashes with using |stderr| in Assertions.h.

Comment 1

[(no longer active)]

Attachment: Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul

Comment 2

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=7b26fbf1e30d

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8417126 [details] [diff] [review]
Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul

Review of attachment 8417126 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/hyphenation/src/hnjstdio.cpp
@@ +8,5 @@
>  // in hnjalloc.h, so that we can use nsIURI and nsIInputStream to specify and
>  // access the dictionary resources.
>  
>  #include "hnjalloc.h"
> +#undef FILE // Undo the damage done in hnjalloc.h

O.O

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a76f959ae7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62a76f959ae7