Closed Bug 1005730 Opened 6 years ago Closed 6 years ago

Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

The hyphenation changes are necessary because hnjalloc.h #defines FILE to
a custom data structure, which clashes with using |stderr| in Assertions.h.
Assignee: nobody → ehsan
Attachment #8417126 - Flags: review?(nfroyd)
Comment on attachment 8417126 [details] [diff] [review]
Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul

Review of attachment 8417126 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/hyphenation/src/hnjstdio.cpp
@@ +8,5 @@
>  // in hnjalloc.h, so that we can use nsIURI and nsIInputStream to specify and
>  // access the dictionary resources.
>  
>  #include "hnjalloc.h"
> +#undef FILE // Undo the damage done in hnjalloc.h

O.O
Attachment #8417126 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/62a76f959ae7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.