1005780 - When cloning a bug, also add the assignee and qa contact to the CC: list of the new bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P3)

Description

[Simon Green]

Attachment: allcc-v1.patch

Currently when cloning a bug, we only copy the reporter to the CC: field of the new bug. We should also copy the assignee and qa_contact (if any)

(NB: $bug->qa_contact returns undef if the Bugzilla installation doesn't support qa_contacts)

Comment 1

[:glob ✱]

Comment on attachment 8417187 [details] [diff] [review]
allcc-v1.patch

Review of attachment 8417187 [details] [diff] [review]:
-----------------------------------------------------------------

::: enter_bug.cgi
@@ +216,5 @@
>      } else {
>          $vars->{'cc'}         = formvalue('cc');
>      }
> +
> +    for my $role (qw(reporter assigned_to qa_contact)) {

use 'foreach' not 'for'

@@ +219,5 @@
> +
> +    for my $role (qw(reporter assigned_to qa_contact)) {
> +        if (defined($cloned_bug->$role)
> +            && $cloned_bug->$role->id != $user->id
> +            && none { $_ eq $cloned_bug->$role->login } @{$cloned_bug->cc}) {

drop that trailing { to the next line to clearly separate the condition from the code block

@@ +220,5 @@
> +    for my $role (qw(reporter assigned_to qa_contact)) {
> +        if (defined($cloned_bug->$role)
> +            && $cloned_bug->$role->id != $user->id
> +            && none { $_ eq $cloned_bug->$role->login } @{$cloned_bug->cc}) {
> +            $vars->{'cc'} = join (", ", $cloned_bug->$role->login, $vars->{'cc'}); 

remove trailing whitespace

Comment 2

[Simon Green]

Attachment: allcc-v2.patch

> use 'foreach' not 'for'
Guess who's been learning Python lately? :)

Comment 3

[:glob ✱]

Comment on attachment 8417189 [details] [diff] [review]
allcc-v2.patch

Review of attachment 8417189 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 4

[Simon Green]

To ssh://git.mozilla.org/bugzilla/bugzilla.git
   b0df54c..85e0d6c  master -> master