1005802 - [Follow up] Create green themed header [BB] for comms apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Per comment: https://bugzilla.mozilla.org/show_bug.cgi?id=985995#c26
Background color should be updated to the latest spec.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Anthony Ricaud (:rik)]

Could you also address bug 985995 comment 26?

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

:rik You mean 27?

Comment 4

[Anthony Ricaud (:rik)]

Yes sorry, bad copy paste.

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8417220 [details] [review]
patch in github

Not too much to add here ;-) Ready to land as soon as Travis is all green ;-) Thanks guys!

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Green and merged: 7cceb7de02a72b8ffecbb0844caf5cac17e0b66b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This made the Gaia integration tests on TBPL perma-fail. Reverted.
Master: https://github.com/mozilla-b2g/gaia/commit/145c03b5b9b9130f4ff66067cfca772f232a14de

https://tbpl.mozilla.org/php/getParsedLog.php?id=39047555&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=39048900&tree=B2g-Inbound

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I guess the error was caused by to references to a deleted SVG file:
- Edit mode Building block
- Messages app

Let's see I now the patch works :)
Last time Travis was green, but as BB are copied to apps in build time, this is difficult to trace.

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys, I just checked that the affected test case apps/calendar/test/marionette/toggle_calendar_test.js reproduces in master so not that sure that the issue is related to the patch proposed in this bug :S

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

For some weird reason we have Travis all green and the integration tests passing (see https://github.com/mozilla-b2g/gaia/pull/19018).

Arnau, would you be so kind to rebase with latest master code and re-push the branch to see if we get the tests passing? They shouldn't if the issue is not solved before you do it ;-) Thanks!

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I've already merged some code included in this PR in bug 1000132.
Background color for comms headers is already in master.
I will rebase this patch and use it only to change SVGs to PNGs.

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8418569 [details] [review]
patch in github

Disabling the review and asking Arnau about the status of this patch :-)

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

please read comment 12 :)
Could you please review it again?

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8418569 [details] [review]
patch in github

Looking good to me ;-) Thanks Arnau!

Comment 16

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 985ce2a6d1f265bc53b57e3aee7b407da999d57f