1005896 - [NFC] Pairing UI unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Kamil Leszczuk [:kamituel]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36




Expected results:

NFC pairing UI (which just landed, see 969277) needs unit tests, as suggested by @Alive. 

As agreed with Arno, I'm working on those. Please assign this bug to me if you have required Bugzilla permissions.

Comment 1

[Kamil Leszczuk [:kamituel]]

I could definitely use NfcManagerUtils.encodeHandoverSelect() for those tests, but I need it to accept bluetooth name as a parameter.

Comment 2

[Kamil Leszczuk [:kamituel]]

Attachment: Proposed test suites.

Tests whether:
- UI is correctly L10n'd (buttons, labels), depending on all variables (Bluetooth adapter on/off, peer device name available/not)
- Buttons are working properly

In addition to tests which has already landed as part of bug 969277 (dialog lifecycle tests), this should cover most important cases.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8423351 [details] [review]
Proposed test suites.

r=me

BTW, I'd like to add test for SNCD.prototype.hide and SNCD.prototype.show, but it's up to you to do in followup.

Comment 4

[Kamil Leszczuk [:kamituel]]

@Alive, whad do you exactly mean? I think (at least some of it) .show()/.hide() is covered already in 'Dialog lifecycle' suite, isn'it it?

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/gaia/commit/2dbc55b3be11cae70ffc379c2f54494299f9de8c