Closed
Bug 1005900
Opened 11 years ago
Closed 11 years ago
Events link in expanded navigation area is broken
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: admix)
Details
Attachments
(2 files)
see attached image indicating the broken link
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → admix.snurnikov
| Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•11 years ago
|
||
Link also now work in mobile version.
Attachment #8417752 -
Flags: review?(cade)
| Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8417752 [details] [review]
https://github.com/mozilla/webmaker.org/pull/721
I don't think the solution here is to special case the title for events.
We should add pages to go underneath the events header that link to the pages on the events platform.
Events Home
link: <eventHost>
Upcoming Events
link: <eventHost>/#!/events
Add Event
link: <eventHost>/#!/add
Event Guides
link: <eventHost>/#!/event-guides
I'm assuming here we have access to the event platform's hostname..
Attachment #8417752 -
Flags: review?(cade) → review-
| Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8417752 [details] [review]
https://github.com/mozilla/webmaker.org/pull/721
Sorry for misunderstanding. Added links underneath the events header now.
Attachment #8417752 -
Flags: review- → review?(cade)
| Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 8417752 [details] [review]
https://github.com/mozilla/webmaker.org/pull/721
This is perfect! Just a couple touch ups to take care of!
Attachment #8417752 -
Flags: review?(cade) → review-
| Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8417752 [details] [review]
https://github.com/mozilla/webmaker.org/pull/721
Made changes.
Attachment #8417752 -
Flags: review- → review?(cade)
| Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 8417752 [details] [review]
https://github.com/mozilla/webmaker.org/pull/721
aweseome stuff, R+
Attachment #8417752 -
Flags: review?(cade) → review+
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/2a904fb416e4f872c10c648354bda0ac2697aeba
[bug1005900] - Added links to events page to the navigation, underneath the events header
| Reporter | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•