1005904 - Premium apps are displayed as free after a search in reviewer tools

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Madalin Cotetiu]

Steps to reproduce:
1. Open the reviewer tools page and go to Queues and select apps from the drop down menu or access this link: https://marketplace.allizom.org/reviewers/apps/queue/
2. Click on the Advanced Search link.
3. In the Premium types section check the Premium box or the Premium with In-app and perform a search by clicking the search button.

Expected results:
A list of apps is displayed, under the Price column the price shouldn't be listed as free.

Actual results:
A list of apps is displayed, under the Price column all the apps are listed as free.

Notes/Issues:
Verified on FF32 (Win 7). Issue can be reproduce on -dev and stage
Screencast for this issue: http://screencast.com/t/nBAO2H24wUD

Comment 1

[Andrew Williamson [:eviljeff]]

fwiw, I'm not seeing this on prod (as of now, before the push today) - I can see premium apps in the queue.

I can't replicate on -dev either - what the screencast shows isn't happening.  Maybe already fixed?

Comment 2

[Madalin Cotetiu]

(In reply to Andrew Williamson [:eviljeff] from comment #1)
> fwiw, I'm not seeing this on prod (as of now, before the push today) - I can
> see premium apps in the queue.
> 
> I can't replicate on -dev either - what the screencast shows isn't
> happening.  Maybe already fixed?

I can still reproduce this on stage and -dev (I cant verify in production as I don't have permissions there)
Are you sure you have followed all the STR in comment 0? For you to see the actual results mentioned in comment 0 you must perform a search first. 
Please view this screencast: http://screencast.com/t/ZEwY2RrEBk
Before i perform a search, under the payments column the correct text is displayed (you can see free, premium..) but after you perform a search under the price column all the apps have the text free.

Comment 3

[Andrew Williamson [:eviljeff]]

Attachment: Screen Shot 2014-05-06 at 14.52.57.png

Comment 4

[Andrew Williamson [:eviljeff]]

the attachment is on -dev

Comment 5

[Victor Carciu]

Andrew : I can reproduce this issue using the original STRs : http://screencast.com/t/ns8VNpDJtR

Comment 6

[Madalin Cotetiu]

(In reply to Andrew Williamson [:eviljeff] from comment #3)
> Created attachment 8418032 [details]
> Screen Shot 2014-05-06 at 14.52.57.png

I can see something strange in your screenshot. You have there some apps flagged as premium but under the price column you have the free text. Test App (reindeer1474) appears to be free in your screenshot but it has a price of 0.10$ http://screencast.com/t/izomeVh8W8m

And I think your screenshot is on stage not dev.

Comment 7

[Andrew Williamson [:eviljeff]]

(In reply to Madalin Cotetiu from comment #6)
> And I think your screenshot is on stage not dev.

yes, it appears it was.

Comment 8

[Andrew Williamson [:eviljeff]]

Attachment: marketplace-dev reviewer tools

-dev this time.

Comment 9

[Rob Hudson [:robhudson]]

It looks like when the price doesn't come through via search we default to 'Free':

https://github.com/mozilla/zamboni/blob/master/media/js/devreg/reviewers/reviewers.js#L125-L127

Comment 10

[Rob Hudson [:robhudson]]

https://github.com/robhudson/zamboni/commit/5888716

Comment 11

[Madalin Cotetiu]

Verified in FF35(Win7) in marketplace-dev.allizom.org
Now when searching for any apps under the price column the "null" text is displayed for all the apps.
Please view this screencast: http://screencast.com/t/Ovi83jvF

Comment 12

[Rob Hudson [:robhudson]]

(In reply to Madalin Cotetiu from comment #11)
> Verified in FF35(Win7) in marketplace-dev.allizom.org
> Now when searching for any apps under the price column the "null" text is
> displayed for all the apps.
> Please view this screencast: http://screencast.com/t/Ovi83jvF

Oops, good catch. I neglected to consider free apps that should be labeled as "Free". This is now fixed: https://github.com/mozilla/zamboni/commit/6f4dbe4 

Premiums apps that have no price (which usually means the payment account has not be set up) are listed as "-" in the price column.

Comment 13

[Madalin Cotetiu]

When searching for free apps the correct "Free" label is displayed:  http://screencast.com/t/LsNjGhbB1pc
For premium apps the "-" is displayed: http://screencast.com/t/qtYtzDpq
As this bug (Bug 1053754) blocks attaching a payment account to an app on dev, I will wait to verify the search for paid app when the fix will land on stage, just to make sure the price is correctly displayed.

Comment 14

[Madalin Cotetiu]

When searching for paid apps under the price column the "-" label is displayed. I have used a test app with a test bango account attached to it
Please view this screencast: http://screencast.com/t/YOp1cUeJVqd

Also when searching for paid apps, all the apps have the "-" label under the the price column
Screencast: http://screencast.com/t/thtLQWPjrdW

Comment 15

[Rob Hudson [:robhudson]]

(In reply to Madalin Cotetiu from comment #14)
> When searching for paid apps under the price column the "-" label is
> displayed. I have used a test app with a test bango account attached to it
> Please view this screencast: http://screencast.com/t/YOp1cUeJVqd
> 
> Also when searching for paid apps, all the apps have the "-" label under the
> the price column
> Screencast: http://screencast.com/t/thtLQWPjrdW

I can't see either of these issues on stage.

1. I searched for "panda" and Premium and see the $0.99 in the price column.
2. When search Premium and no search term I see a mix of prices and a couple "-" without price.

Can you share the URLs and let me know if this is dev or stage? Thanks.

Comment 16

[Madalin Cotetiu]

That's strange, it happens for me every time when searching for premium apps.

This is happening in stage.
https://marketplace.allizom.org/reviewers/apps/queue/

I have also tried with a clean profile and in private browsing with the same results. I have tried this on 2 different machines with 2 different accounts and i still could reproduce it.

Comment 17

[Rob Hudson [:robhudson]]

(In reply to Madalin Cotetiu from comment #16)
> That's strange, it happens for me every time when searching for premium apps.
> 
> This is happening in stage.
> https://marketplace.allizom.org/reviewers/apps/queue/
> 
> I have also tried with a clean profile and in private browsing with the same
> results. I have tried this on 2 different machines with 2 different accounts
> and i still could reproduce it.

Could you show me what the network panel shows as the response when searching? It should be one of the only GET calls. In the array of objects if the "price" is null it shows the "-", otherwise it should show the price.

Comment 18

[Madalin Cotetiu]

This is the request when searching for a paid app (Panda): http://screencast.com/t/UuO19fwZDqW 
http://screencast.com/t/shapIsuAgxl

This is when searching for all paid apps: http://screencast.com/t/GbrcfWwxK
http://screencast.com/t/TCr3H7Zj

Comment 19

[Rob Hudson [:robhudson]]

Andy helped me spot the difference. Your sending region=restofworld while I'm sending region=us. And since pricing depends on region you get back null while I get back a USD price.

If you change to region=us I believe you could verify this bug as fixed.

Comment 20

[Rob Hudson [:robhudson]]

I'm closing again as fixed based on comment 19.

Comment 21

[Madalin Cotetiu]

Verified as fixed in FF39(Win7) in mp-stage.
Postfix screencast: http://screencast.com/t/VC2EpLix1XVa
Closing bug.