Closed Bug 1005917 Opened 10 years ago Closed 10 years ago

Skip "system" apps like operatorvariant

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::PerformanceTest
Platform:
x86_64
Linux
Type:
defect

Tracking

(b2g-v1.3T affected, b2g-v1.4 wontfix, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v1.3T --- affected
b2g-v1.4 --- wontfix
b2g-v2.0 --- fixed

People

(Reporter: hub, Assigned: hub)

References

Details

(Whiteboard: [c=automation p=1 s=2014.05.09 u=])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18952
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
This is a follow up from bug 1001951

Blacklist the "operatorvariant" app from testing. Its testing is irrelevant.
Assignee: nobody → hub
Priority: -- → P2
Whiteboard: [c=automation p=1 s= u=]
Status: NEW → ASSIGNED
Comment on attachment 8417480 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18952

added a comment on github; basically we can try to rely on the role property of manifest.webapp.

Please request the review again if you disagree or if you have a new patch.
Attachment #8417480 - Flags: review?(felash)
Renaming the bug.

Will make the solution more generic by checking the manifest as suggested in comment 2
Summary: Blacklist operatorvariant → Skip "system" apps like operatorvariant
Comment on attachment 8417480 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18952

Reworked completely.
Attachment #8417480 - Flags: review?(felash)
Priority: P2 → P1
See Also: → 1005363
Blocks: 1005363
Comment on attachment 8417480 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18952

r=me with the nits
Attachment #8417480 - Flags: review?(felash) → review+
Merged

https://github.com/mozilla-b2g/gaia/commit/33a8aff5177fb5e86678567e8fd36d696b765793
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v1.3T: --- → affected
status-b2g-v1.4: --- → wontfix
status-b2g-v2.0: --- → fixed
Resolution: --- → FIXED
Whiteboard: [c=automation p=1 s= u=] → [c=automation p=1 s=2014.05.09 u=]
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: