Closed Bug 1005942 Opened 10 years ago Closed 10 years ago

Investigate Undo Close Tab not working in 29

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
29 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox29 + verified
firefox30 --- verified
firefox31 --- verified
firefox32 --- verified

People

(Reporter: tdowner, Assigned: ttaubert)

References

Details

After 29 was released we are seeing reports of lots of users who say that Undo Close Tab is broken, the keyboard shortcut doens't work, and the menu options are greyed out. We are currently investigating but wanted to get this bug on file first.
It appears this may be because sessionstore is borked.

https://support.mozilla.org/en-US/questions/988720
Yeah this would be a sessionstore issue.
Component: General → Session Restore
Seems like people are hitting bug 1001167 which we didn't manage to fix in time for 29 :/
Since that is a low risk patch can we get it into 29.0.1?
To be clear, we didn't even know it was a problem until a week ago. There were no bug reports about it so far and we found by chance. I am just assuming that people are seeing a broken sessionstore initialization as it very much sounds like it. Especially the last reply seems to support that assumption.
(In reply to Tyler Downer [:Tyler] from comment #4)
> Since that is a low risk patch can we get it into 29.0.1?

It is indeed a very low risk patch. Are there plans for a 29.0.1? I don't think this alone would justify a chemspill?
Blocks: 1001167
There at least 2 other bugs that are getting investigated for a 29.0.1, so this would be a nice ride along.
Ok, if we have a 29.0.1 I really think we should include this as well. I can provide more information for an approval process if needed.
The patch on bug 1001167 got landed on mozilla-release for 29.0.1. So I assume we are good to get this bug closed? Tim, would we need any other kind of tests, or are the ones as landed in the testsuite enough?
Flags: needinfo?(ttaubert)
The one in the test suite really should be enough. If you really want you can of course still verify bug 1001167 for 29.0.1 again :)
Flags: needinfo?(ttaubert)
Thanks, but the final verification is up for QA. So we can also close this bug?
Yes. Fixed by uplifting bug 1001167 to the release branch.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on Firefox 29.0.1, build ID: 20140506152807.
Status: RESOLVED → VERIFIED
status-firefox29: fixed → verified
Keywords: qawanted
QA Contact: cornel.ionce
Assignee: nobody → ttaubert
status-firefox30: --- → fixed
status-firefox31: --- → fixed
status-firefox32: --- → fixed
Target Milestone: --- → Firefox 32
Verified as fixed on Windows 7 x64, Ubuntu 13.04 and Mac OS X 10.8.5 using:

1. Firefox 30, build ID: 20140605174243
2. Firefox 31 beta 5, build ID: 20140626181429
3. Latest Aurora, build ID:
status-firefox30: fixed → verified
status-firefox31: fixed → verified
status-firefox32: fixed → verified
Keywords: verifyme
Missed the Aurora build ID in the above comment: 20140630004007
You need to log in before you can comment on or make changes to this bug.