1005966 - Add a pref to control whether to use WebIDL bindings for Window

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8417451 [details] [diff] [review]
v1

>+    if (!aGlobal || !xpc::InitGlobalObject(aCx, aGlobal, flags)) {

We should document that InitGlobalObject does not expect aCx to be in the compartment of aGlobal and will enter that compartment itself.

>+      if (IsDOMObject(newInnerGlobal)) {

Why not newInnerWindow->IsDOMBinding()?  If there's a reason, it's worth documenting here.

Also, are we in the compartment of newInnerGlobal at this point?

r=me

Comment 2

[Peter Van der Beken [:peterv]]

(In reply to Boris Zbarsky [:bz] from comment #1)
> >+      if (IsDOMObject(newInnerGlobal)) {
> 
> Why not newInnerWindow->IsDOMBinding()?  If there's a reason, it's worth
> documenting here.

No, should be equivalent. Switched to IsDOMBinding.

> Also, are we in the compartment of newInnerGlobal at this point?

We've switched to the outer's compartment that newInnerGlobal is the inner of (there's a |JSAutoCompartment ac(cx, GetWrapperPreserveColor());| just above).

Comment 3

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a47f2528143

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a47f2528143