Closed
Bug 1005980
Opened 10 years ago
Closed 10 years ago
Make nsGlobalWindow::OuterObject throw when it fails
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It's what XPConnect used to do, and we hit that in a devtools test (at least now we warn about it too :-/).
Attachment #8417462 -
Flags: review?(bzbarsky)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8417462 [details] [diff] [review] v1 r=me
Attachment #8417462 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
The change from UNWRAP_OBJECT to UnwrapDOMObject is because we know we have a Window object, so no need for the extra stuff that UNWRAP_OBJECT checks.
|
|
||
Comment 3•10 years ago
|
||
Yes, that was pretty clear, at least to me. ;)
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a34412a9f079
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a34412a9f079
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•