1005984 - Don't generate APKs for apps incompatible with Android

Status: RESOLVED FIXED

(Marketplace Graveyard :: Integration, defect, P3)

Description

[Mathieu Pillard [:mat]]

STR:
- Upload an app compatible with Firefox OS or Firefox Desktop only, *not* Android.
- Observe in the logs that an APK is generated for it even though it's useless

in mkt/webapps/models.py pre_generate_apk(), we should check for compatible devices before calling the actual task.

Comment 1

[Kumar McMillan [:kumar]]

https://github.com/mozilla/zamboni/pull/2076

Comment 2

[Kumar McMillan [:kumar]]

For QA, it would be nice if you could also help verify that APKs are pre-generated. That is, in addition to the STR above:

- upload a new Android app
- install it on Android

If the APK was pre-generated you will see it install very quickly. Otherwise, it will take a few seconds to install.

Comment 3

[Iulian Timis]

I have uploaded a packaged app on https://marketplace-dev.allizom.org/ and then installed it on my Android 4.2.1 device. It took like 20 seconds from the press of the "Free" button to the Install window.
https://marketplace-dev.allizom.org/app/droid-packed/

Comment 4

[Kumar McMillan [:kumar]]

Could you try uploading a new app again? It looks like there was a problem but now it's fixed.

When you uploaded the app, the manifest could not be fetched which was preventing the APK from being pre-generated. The manifest URL was returning a 400: 

PreGenAPKError: Error pre-generating APK for app 490148: Dev at https://marketplace-dev.allizom.org/app/f34d3c22-3efe-47ca-803d-6c740da1a851/manifest.webapp; generator=http://dapk.net/application.apk (SSL cert ok?); HTTPError: 400 Client Error: Bad Request
Details: http://sentry.dmz.phx1.mozilla.com/marketplace-dev/marketplace-dev/group/19083/

However, I just tried the manifest URL and it's a 200 now:
curl -v 'https://marketplace-dev.allizom.org/app/f34d3c22-3efe-47ca-803d-6c740da1a851/manifest.webapp'

Comment 5

[Iulian Timis]

I have uploaded a new app but I have encountered the same issue again https://marketplace-dev.allizom.org/app/papple-packed/
It still takes about 20 seconds until the Install window is displayed.

Comment 6

[Kumar McMillan [:kumar]]

Thanks for helping us find this new issue. Since this may not be related to my changes, I opened bug 1017098 to track the specific problem where manifests can't be retrieved. It appears that the pre-generation task is indeed running so I'm closing this. Since it can't be verified until the 400 issue is fixed, I'll mark it qa-