Closed Bug 1006026 Opened 7 years ago Closed 7 years ago
distclean target broken, recurses into mfbt/tests twice
Needed to fix bug 1005759 (make source-package) for in-sourcetree source-package rolling, but this is a bug in and of itself too. steps to reproduce: cd js/src autoconf-2.13 ./configure make distclean Result: make -C config distclean make: Entering directory `/path/to/mc/js/src/config' [...] make: Leaving directory `/path/to/mc/js/src/config' make -C python distclean make: Entering directory `/path/to/mc/js/src/python' [...] make: Leaving directory `/path/to/mc/js/src/python' make -C mfbt distclean make: Entering directory `/path/to/mc/js/src/mfbt' make -C tests distclean make: Entering directory `/path/to/mc/js/src/mfbt/tests' [...] make: Leaving directory `/path/to/mc/js/src/mfbt/tests' make -C tests distclean make: Entering directory `/path/to/mc/js/src/mfbt/tests' make: *** No rule to make target `distclean'. Stop. make: Leaving directory `/path/to/mc/js/src/mfbt/tests' make: *** [distclean] Error 2 make: Leaving directory `/path/to/mc/js/src/mfbt' make: *** [distclean] Error 2
Somehow we ended up with this duplicate rule. As you can see, it's redundant with the rule just above it and causes problems by trying to do things twice.
Attachment #8418752 - Flags: review?(mshal)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment on attachment 8418752 [details] [diff] [review] remove duplicate distclean:: rule in rules.mk [Approval Request Comment] Bug caused by (feature/regressing bug #): changes to build system between mozilla-24 and mozilla-31 User impact if declined: 'make distclean' fails in js/src, source package for spidermonkey/mozjs-31 cannot be rolled Testing completed (on m-c, etc.): confirmed working on aurora and m-c checkouts, locally Risk to taking this patch (and alternatives if risky): none String or IDL/UUID changes made by this patch: none
Attachment #8418752 - Flags: approval-mozilla-aurora?
Attachment #8418752 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.