Closed
Bug 1006026
Opened 10 years ago
Closed 10 years ago
distclean target broken, recurses into mfbt/tests twice
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: axs, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
950 bytes,
patch
|
mshal
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Needed to fix bug 1005759 (make source-package) for in-sourcetree source-package rolling, but this is a bug in and of itself too. steps to reproduce: cd js/src autoconf-2.13 ./configure make distclean Result: make -C config distclean make[1]: Entering directory `/path/to/mc/js/src/config' [...] make[1]: Leaving directory `/path/to/mc/js/src/config' make -C python distclean make[1]: Entering directory `/path/to/mc/js/src/python' [...] make[1]: Leaving directory `/path/to/mc/js/src/python' make -C mfbt distclean make[1]: Entering directory `/path/to/mc/js/src/mfbt' make -C tests distclean make[2]: Entering directory `/path/to/mc/js/src/mfbt/tests' [...] make[2]: Leaving directory `/path/to/mc/js/src/mfbt/tests' make -C tests distclean make[2]: Entering directory `/path/to/mc/js/src/mfbt/tests' make[2]: *** No rule to make target `distclean'. Stop. make[2]: Leaving directory `/path/to/mc/js/src/mfbt/tests' make[1]: *** [distclean] Error 2 make[1]: Leaving directory `/path/to/mc/js/src/mfbt' make: *** [distclean] Error 2
Assignee | ||
Comment 1•10 years ago
|
||
Somehow we ended up with this duplicate rule. As you can see, it's redundant with the rule just above it and causes problems by trying to do things twice.
Attachment #8418752 -
Flags: review?(mshal)
Updated•10 years ago
|
Attachment #8418752 -
Flags: review?(mshal) → review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/72b41e294442
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/72b41e294442
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8418752 [details] [diff] [review] remove duplicate distclean:: rule in rules.mk [Approval Request Comment] Bug caused by (feature/regressing bug #): changes to build system between mozilla-24 and mozilla-31 User impact if declined: 'make distclean' fails in js/src, source package for spidermonkey/mozjs-31 cannot be rolled Testing completed (on m-c, etc.): confirmed working on aurora and m-c checkouts, locally Risk to taking this patch (and alternatives if risky): none String or IDL/UUID changes made by this patch: none
Attachment #8418752 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox31:
--- → affected
status-firefox32:
--- → fixed
Updated•10 years ago
|
Attachment #8418752 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•