1006032 - Choose better identifiers for l10n resources for NFC-BT messages.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[arno]

Choose better identifiers for l10n resources to help translators.

Comment 1

[arno]

Based on the discussions for bug 969277 in comment 44, the following changes will be made:

Change the 'n' to 'device-name'. The other identifiers need to encode two variables: whether Bluetooth is enabled or disabled and whether the device name is known or not:

confirmNFCConnectBTenabledNameKnown
confirmNFCConnectBTenabledNameUnknown
confirmNFCConnectBTdisabledNameKnown
confirmNFCConnectBTdisabledNameUnknown

Comment 2

[arno]

Attachment: Choose better l10n identifiers

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8417531 [details] [review]
Choose better l10n identifiers

Thanks, those look good to me.

Alive, we're currently holding on exposing new strings to localizers on master to avoid duplicate work, so if you could put this to the top of your review queue, that'd be great. Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Axel Hecht [:Pike] from comment #3)
> Comment on attachment 8417531 [details] [review]
> Choose better l10n identifiers
> 
> Thanks, those look good to me.
> 
> Alive, we're currently holding on exposing new strings to localizers on
> master to avoid duplicate work, so if you could put this to the top of your
> review queue, that'd be great. Thanks.

Please let us know when is the best timing to merge. Thanks.

Comment 5

[arno]

Attachment: Choose better l10n identifiers. r=alive

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Alive Kuo [:alive][NEEDINFO!][OOO 4/30 - 5/4] from comment #4)
> Please let us know when is the best timing to merge. Thanks.

The sooner the better ;-)

Basically we stopped exposing strings to l10n, we can restart as soon as this lands.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/db9810008bbb9879dc0c3f5d5c144a63059a7abd