Closed Bug 1006139 Opened 6 years ago Closed 6 years ago
All caching is broken
ContactDispatcher calls Array.splice which modifies the array it receives... Other code assumes that the array is unmodified and stores it away for later use. This leads to badness. Also, we were calling a failure callback when we meant to be calling a success callback...
Attachment #8417655 - Flags: review?(anygregor)
Attachment #8417655 - Flags: review?(anygregor) → review+
Blocking a blocker.
blocking-b2g: 1.4? → 1.4+
Oh wow. Nice catch… Took me a while to realize what was going on because of the asyncness of the code/bug.
nasty bug ! Why is it necessary to land bug 980549 ? Also, why no tests ?
(In reply to Julien Wajsberg [:julienw] (away until 5th May) from comment #6) > Why is it necessary to land bug 980549 ? > Also, why no tests ? Well, the fix for bug 980549 causes test_getAllContacts.html to go orange, so we can't land bug 980549 without this, and we then do have test coverage :)
Assignee: nobody → bent.mozilla
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.