Closed
Bug 1006152
Opened 10 years ago
Closed 10 years ago
[flame] MozBuild ROM does not use HWComposer
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(blocking-b2g:1.4+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
People
(Reporter: sotaro, Assigned: sotaro)
Details
Attachments
(1 file, 3 obsolete files)
2.17 KB,
patch
|
sushilchauhan
:
review+
|
Details | Diff | Splinter Review |
I built a rom for flame device, the rom does not have "ro.display.colorfill" property. Then HwComposer is disabled.
Assignee | ||
Comment 1•10 years ago
|
||
Confrimed that the patch works on flame device.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8417671 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8417678 -
Flags: review?(mwu)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sotaro.ikeda.g
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Comment 3•10 years ago
|
||
Comment on attachment 8417678 [details] link to pull request According to http://hg.mozilla.org/mozilla-central/file/7dcb8e0d9668/widget/gonk/HwcComposer2D.cpp#l103 , ro.display.colorfill is only used on ICS. On JB/KK, we query the hwc module to determine colorfill support.
Attachment #8417678 -
Flags: review?(mwu) → review-
Assignee | ||
Comment 4•10 years ago
|
||
Mwu, I created the patch because it is still used in the following. Can I have the comment about the following? http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#572
Flags: needinfo?(mwu)
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #4) > Mwu, I created the patch because it is still used in the following. Can I > have the comment about the following? > http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings. > js#572 The following is the correct line. http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#565
Comment 6•10 years ago
|
||
Ah ok. That behavior shouldn't be relied on with JB and up. On JB and up, I think we should turn compositing on by default in the prefs since we have colorfill and rb swap support detection.
Flags: needinfo?(mwu)
Assignee | ||
Comment 7•10 years ago
|
||
Thanks. That seems reasonable.
Assignee | ||
Updated•10 years ago
|
Summary: [flame] MozBuild does not set "ro.display.colorfill" → [flame] MozBuild ROM does not use HWComposer
Assignee | ||
Comment 8•10 years ago
|
||
I confirmed the patch works correctly on master flame and master nexus-5.
Assignee | ||
Updated•10 years ago
|
Attachment #8419411 -
Flags: review?(sushilchauhan)
Attachment #8419411 -
Flags: review?(dwilson)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 8419411 [details] [diff] [review] patch - Do not use "ro.display.colorfill" since JB if (typeof(req.result['layers.composer2d.enabled']) === 'undefined') { - var enabled = false; + var enabled = true; There is problem here. When MOZ_WIDGET_GONK is not defined, then line # 569 will always set "layers.composer2d.enabled" to True: navigator.mozSettings.createLock().set({'layers.composer2d.enabled': enabled }); I am not sure on which platforms, MOZ_WIDGET_GONK switch is not defined.
Attachment #8419411 -
Flags: review?(sushilchauhan)
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Sushil from comment #9) > Comment on attachment 8419411 [details] [diff] [review] > patch - Do not use "ro.display.colorfill" since JB > > if (typeof(req.result['layers.composer2d.enabled']) === 'undefined') { > - var enabled = false; > + var enabled = true; > > There is problem here. When MOZ_WIDGET_GONK is not defined, then line # 569 > will always set "layers.composer2d.enabled" to True: > navigator.mozSettings.createLock().set({'layers.composer2d.enabled': enabled > }); > > I am not sure on which platforms, MOZ_WIDGET_GONK switch is not defined. MOZ_WIDGET_GONK is defined only on b2g device that used android base platform. b2g does not have this definition. But HWComposer is only defined only on GONK. Therefore it should not becomes a problem.
Assignee | ||
Comment 11•10 years ago
|
||
Anyway it seems safer to update the patch.
Assignee | ||
Comment 12•10 years ago
|
||
During debugging, I recognized that we can not use ANDROID_VERSION in js code.
Assignee | ||
Comment 13•10 years ago
|
||
Apply comment and remove ANDROID_VERSION.
Attachment #8419411 -
Attachment is obsolete: true
Attachment #8419411 -
Flags: review?(dwilson)
Assignee | ||
Updated•10 years ago
|
Attachment #8419564 -
Flags: review?(sushilchauhan)
Attachment #8419564 -
Flags: review?(dwilson)
Comment 14•10 years ago
|
||
Comment on attachment 8419564 [details] [diff] [review] patch v2 - Do not use "ro.display.colorfill" since JB LGTM. Please make sure Disable/Enable HWC from Settings, is not broken.
Attachment #8419564 -
Flags: review?(sushilchauhan) → review+
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8419564 [details] [diff] [review] patch v2 - Do not use "ro.display.colorfill" since JB Sushil's review is enough for the check-in.
Attachment #8419564 -
Flags: review?(dwilson)
Assignee | ||
Updated•10 years ago
|
Attachment #8417678 -
Attachment is obsolete: true
Assignee | ||
Comment 16•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/f49f0bcf49da
Comment 17•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f49f0bcf49da
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•10 years ago
|
||
Set "1.4?" flag. Without this fix, MozBuild rom does not use HwComposer on b2g v1.4 flame.
blocking-b2g: --- → 1.4?
Comment 20•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/1de9a17bf032
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → wontfix
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•