1006229 - Assert that AudioBuffer::SetRawChannelContents cannot be called on AudioBuffer objects which might have a neutered buffer

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

AudioBuffer's typed arrays can be neutered in two ways:

* C++ code calling AudioBuffer::GetThreadSharedChannelsForRate.
* The object being handed off to JS.

SetRawChannelContents is only safe if the typed arrays have not been neutered.

I think the following in SetRawChannelContents will assert the summary of this bug:

MOZ_ASSERT(!GetWrapperPreserveColor() && !mSharedChannels, "The AudioBuffer object should not have been handed to JS or have C++ callers neuter its typed array");

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Please verify that comment 0 makes sense!  Thanks.

Comment 2

[(no longer active)]

Comment on attachment 8423141 [details] [diff] [review]
Patch (v1)

[Security approval request comment]
How easily could an exploit be constructed based on the patch? This is just an assertion to prevent future security bugs.

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem? This is just an assertion to prevent future security bugs.

Which older supported branches are affected by this flaw? This only needs to land on trunk.

If not all supported branches, which bug introduced the flaw?

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

How likely is this patch to cause regressions; how much testing does it need?  A debug-only assertion, 0 risk.

Comment 3

[Al Billings [:abillings - ex-MoCo]]

Comment on attachment 8423141 [details] [diff] [review]
Patch (v1)

If this is a sec-audit rated issue, it doesn't need a sec-approval to go in.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9966d1b73aa5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9966d1b73aa5

Comment 6

[Matt Wobensmith [:mwobensmith][:matt:]]

Fix pertains to an audit without exploitable bug. If a test materializes or if you'd like QE to look at this, say the word. Marking qaverify- for now.