1006231 - Style Editor should load original source's content from the map's `sourcesContent` if it exists

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Heather Arthur [:harth]]

Right now the Style Editor fetches the content of the original source from its resolved location. We should be getting the content from the `sourcesContent` property of the source map, if it exists.

The debugger does this already. We should really share some of this code at some point.

Comment 1

[Heather Arthur [:harth]]

Attachment: Look at 'sourcesContent' before fetching, add test for self contained sourcemap

Small fix. Also refactored the source maps test and added a test for a self contained sourcemap in a data url.

Fixed a "TypeError: this.rawSheet.ownerNode.ownerDocument.location is null" that was cropping up when I ran the test.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8419192 [details] [diff] [review]
Look at 'sourcesContent' before fetching, add test for self contained sourcemap

Review of attachment 8419192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

Comment 3

[Heather Arthur [:harth]]

Attachment: To check in, patch with orange fix

Patch from before, but with a test change to fix an intermittent it introduced. Try: https://tbpl.mozilla.org/?tree=Try&rev=a5799f0a6a54

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/6719d530f795

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6719d530f795

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Heather, we should probably uplift this, yeah?

Comment 7

[Heather Arthur [:harth]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #6)
> Heather, we should probably uplift this, yeah?

Yeah, def, let's wait a bit for it to bake.

Comment 8

[Heather Arthur [:harth]]

Comment on attachment 8419741 [details] [diff] [review]
To check in, patch with orange fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
bug 926014

User impact if declined: 

A significant number of people using source maps in the developer tools will see empty files in the Style Editor - making it useless. One user reached out over twitter to report this bug.

Testing completed (on m-c, etc.):

This has been on mozilla-central for several days, has tests.

Risk to taking this patch (and alternatives if risky):

Nothing known.

String or IDL/UUID changes made by this patch:

None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/32b62ac2705d

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Heather, should I mark this as being in-testsuite? You mentioned it has tests but didn't flag it.

Comment 11

[Heather Arthur [:harth]]

It does have tests, yes.