1006287 - Click on an audionode in the graph should focus the node in the paramslist

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

This was previously implemented but no longer worked after some refactoring.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1006287-focus-paramlist-on-graph-click.patch

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=1cecfae80429

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Also removed a duplicate test (browser_wa_graph_mouseover.js) as it was a duplicate of the params list mouse over test, and was originally a placeholder for this functionality

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8418397 [details] [diff] [review]
1006287-focus-paramlist-on-graph-click.patch

Review of attachment 8418397 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webaudioeditor/test/browser_wa_graph_click.js
@@ +15,5 @@
> +  let started = once(gFront, "start-context");
> +
> +  reload(target);
> +
> +  let [_, nodes, __] = yield Promise.all([

Why the __?

::: browser/devtools/webaudioeditor/webaudioeditor-view.js
@@ +222,5 @@
>     */
> +  _onGraphNodeClick: function (e) {
> +    let node = findGraphNodeParent(e.target);
> +    if (!node)
> +      return;

When can this happen? Care to add a comment?

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Ah yeah can reuse variable name. `!node` will happen when not clicking on a node, but still within the graph, as no ancestor node will exist (and bubble up to the svg wrapper parent)

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1006287-focus-paramlist-on-graph-click.patch

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/618f692cbd11

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/618f692cbd11