Closed Bug 1006288 Opened 7 years ago Closed 7 years ago

add File::Slurp to the list of mandatory modules

Categories

(Bugzilla :: Installation & Upgrading, defect)

Product:
Bugzilla
Component:
Installation & Upgrading
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(2 files)

1006288_1.patch (trunk)
461 bytes, patch
dkl
: review+
Details | Diff | Splinter Review
1006288-4.4_1.patch (4.4)
472 bytes, patch
dkl
: review+
Details | Diff | Splinter Review 
bug 832893 added a dependency on File::Slurp without adding it to the list of mandatory modules.

it's a very common module, is most likely already installed on systems, and brings readability and performance benefits over "undef $/" slurping.

we should add it to our mandatory module list.
File::Slurp is not mandatory in 4.4. If you don't use jobqueue, you don't need it to be installed. So it should be listed as optional for 4.4 (and this way, this won't break installations which don't have this module installed). But for trunk, it becomes mandatory due to bug 977969.
Assignee: general → installation
Blocks: 977969
Component: Bugzilla-General → Installation & Upgrading
Depends on: 832893
Keywords: relnote
Flags: blocking4.4.5+
i'd prefer to require 9999.14 as a minimum version, however .13 is the version on to RHEL :(
Assignee: installation → glob
Status: NEW → ASSIGNED
Attachment #8417894 - Flags: review?(dkl)
Attachment #8417894 - Attachment description: 1006288_1.patch → 1006288_1.patch (trunk)
Attachment #8417898 - Flags: review?(dkl)
Comment on attachment 8417894 [details] [diff] [review]
1006288_1.patch (trunk)

Review of attachment 8417894 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8417894 - Flags: review?(dkl) → review+
Comment on attachment 8417898 [details] [diff] [review]
1006288-4.4_1.patch (4.4)

Review of attachment 8417898 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8417898 - Flags: review?(dkl) → review+
Flags: approval?
Flags: approval4.4?
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   52b113c..fca0b6c  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   ad99e9d..ea23299  4.4 -> 4.4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Added to relnotes for 5.0rc1.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.