100629 - [ActiveX] Share IWebBrowser::Navigate code between plugin and control

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The ActiveX control wrapper is not passing through headers and postdata properly
(params 4 & 5) to Gecko during navigation.

Comment 1

[Adam Lock]

Attachment: Work in progress

This more or less complete patch, fixes the following issues with Navigate:

Target param works (_blank, _top, _parent etc.)
Postdata param works
Headers param works

I'm fairly satisfied that the code is correct here though I have have yet to
verify it works correctly. Cursory testing indicates postdata is okay, but I'm
not sure docshell is propogating the headers data through in the loadURI call.

Comment 2

[Adam Lock]

Attachment: More work in progress

Patch is almost complete, save for a way to verify postdata and headers work. I
notice docshell completely ignores the headers arg on nsIWebNavigation. The new
patch uses window watcher to find the named target window.

Comment 3

[Kevin Tam]

I just wanted to note that the lack of ability to pass headers is a roadblock 
for me to use Mozilla in place of IE in my application. If the patch is put 
into a release I'll be more than happy to test this and provide UAT feedback!

Comment 4

[Adam Lock]

I'm hijacking this bug to also cover some work I'm doing to factor out the
entire IWebBrowser2 implementation so it can be used by the plugin and the
control. Expect a massive patch soon...

Comment 5

[Adam Lock]

Attachment: Patch

This patch takes all IWebBrowser / IWebBrowserApp / IWebBrowser2 out of the
Mozilla control and stuffs it in IWebBrowserImpl.h. The control's
CBrowserControl derives from this and so does plugin's IEBrowser object. So the
plugin now benefits from a near complete implementation of these interfaces.
The plugin class also contains an implementation of IHlinkFrame.

For the most part, the code has just been cut and pasted over, however the
Navigate method now also processes its headers, postdata and target arguments.
Combined with the patch I did for bug 181903 this fixes that issue too.

Rick, do you want to look through this?

Comment 6

[rpotts (gone)]

Comment on attachment 107384 [details] [diff] [review]
Patch

sr=[e-mail]

Comment 7

[Adam Lock]

Comment on attachment 107384 [details] [diff] [review]
Patch

Hi Chak, can you review this please? It's not as big as it looks, most of the
diff is just moving the code from MozillaBrowser.cpp into IWebBrowserImpl.h

Comment 8

[Chak Nanga]

Comment on attachment 107384 [details] [diff] [review]
Patch

r=chak

Comment 9

[Adam Lock]

Thanks all, fix is checked in.

Comment 10

[Kevin Tam]

Does this mean this will have made it into the 13 December release of Moz 1.3a?

I want to test this!