1006298 - TPS fails to download virtualenv due to the redirect

Status: RESOLVED FIXED

(Testing Graveyard :: TPS, defect)

Description

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Something has been changed recently on github so grabbing the virtualenv script from https://raw.github.com/pypa/virtualenv/1.9.1/virtualenv.py redirects to another URL. Given that we use curl without the -L option, we actually don't download the script, and fail in setting up tps.

We have to get this fixed so the CI will work again.

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Attachment: Add '-L' option to curl command v1

Very simple fix for this bustage, and Glob is that kind to give a sanity review. Just in case.

Comment 2

[:glob 🎈]

Comment on attachment 8417825 [details] [diff] [review]
Add '-L' option to curl command v1

Review of attachment 8417825 [details] [diff] [review]:
-----------------------------------------------------------------

| curl -L https://raw.github.com/pypa/virtualenv/1.9.1/virtualenv.py | on my fedora system results in a HTTP/400 error, however it works fine from my mac.

however given the same fix worked on bug 1002039, r=glob

Comment 3

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

https://hg.mozilla.org/mozilla-central/rev/87c8f870e2b9

Comment 4

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Landed with a=testonly on mozilla-aurora and mozilla-beta:

https://hg.mozilla.org/releases/mozilla-aurora/rev/578c5cbd1dbe
https://hg.mozilla.org/releases/mozilla-beta/rev/da8b1c15e2b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/da8b1c15e2b1