1006375 - [NFC] NfcManager handleTechnologyDiscovered tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36

Steps to reproduce:

As handledTechnologyDiscovered method deals with main NFC functionalities we need to provide tests for it before starting to work on any refactoring in other bugs.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

I would like to work on this.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I've requested editbugs permission for Krzysztof, it should be working now.
Please let me know if you still cannot take the bug.

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1006375.txt

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8442675 [details] [review]
pull-request-1006375.txt

There is no obvious errors and it helps to improve our tests. Unfortunately it conflicts with the current master, so please solve them than I can set the r+. Thanks!

Comment 5

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8442675 [details] [review]
pull-request-1006375.txt

When I was uploading the patch the latests changes in gaia were not present. Rebased and resolved conflicts. Travis is green now. Can you take a look once more?

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8442675 [details] [review]
pull-request-1006375.txt

When I come back it conflict again, which may be caused by some LockScreen patchs that reverted recently. I think once you resolve it we can merge it as soon as possible, thanks.

r+ according to the previous patch, which keeps the major content during the conflict resolving.

Comment 7

[Krzysztof Mioduszewski[:tauzen]]

Yes, it was conflicted with the LockScreen revert. I solved the conflicts and pushed the updated version to github. Once Gaia-Try is ok can I add checkin-needed? Or do I have to wait for travis also? It seems that all travis builds are failing right now.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

It bothers me as well. However one of my colleague told me that he encountered the similar case once and the patch had been landed according to the TBPL result. So I think it's OK to land your patch.

Comment 9

[Krzysztof Mioduszewski[:tauzen]]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=65477f1f8207546afdc788a9182a9a2088658161

Comment 10

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/2d0b102b0f63e19bf2bdb5f6e3a84807c092fc1d