Closed Bug 1006469 Opened 6 years ago Closed 6 years ago

Fix test_cards_view_with_two_apps.py, flicks in wrong direction

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86_64
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: AndreiH, Unassigned)

References

Details

(Whiteboard: [xfail])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
zcampbell
: review+
jlorenzo
: review-
Details | Review
This still needs to be investigated and worked on though this is affected by Bug 946130. Let's see what we can do
This currently fails on travis
Attachment #8418000 - Flags: review?(zcampbell)
Attachment #8418000 - Flags: review?(florin.strugariu)
Attachment #8418000 - Flags: review?(florin.strugariu) → review-
We'll use the wait from Johan's pull request.
Depends on: 1003175
Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

r-, remove the `return` and let's adapt jlorenzo's wait from the other pull. this can wait one more day
Attachment #8418000 - Flags: review?(zcampbell) → review-
Whiteboard: [xfail]
Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

Pls review this again
Attachment #8418000 - Flags: review?(zcampbell)
Attachment #8418000 - Flags: review?(florin.strugariu)
Attachment #8418000 - Flags: review-
Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

r+ ! works well.
I'll give the review to Jlorenzo as he knows the area well and bebe is busy today.
Attachment #8418000 - Flags: review?(zcampbell)
Attachment #8418000 - Flags: review?(jlorenzo)
Attachment #8418000 - Flags: review?(florin.strugariu)
Attachment #8418000 - Flags: review+
Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

Updated this, zac merge?
Flags: needinfo?(zcampbell)
https://github.com/mozilla-b2g/gaia/commit/08971d90965084914d548b23a45b19657583d0df
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(zcampbell)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.