1006469 - Fix test_cards_view_with_two_apps.py, flicks in wrong direction

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[[:AndreiH]]

This still needs to be investigated and worked on though this is affected by Bug 946130. Let's see what we can do

Comment 1

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/18987

This currently fails on travis

Comment 2

[Zac C (:zac)]

We'll use the wait from Johan's pull request.

Comment 3

[Zac C (:zac)]

Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

r-, remove the `return` and let's adapt jlorenzo's wait from the other pull. this can wait one more day

Comment 4

[[:AndreiH]]

Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

Pls review this again

Comment 5

[Zac C (:zac)]

Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

r+ ! works well.
I'll give the review to Jlorenzo as he knows the area well and bebe is busy today.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

Works well too. I think that there is a small nit to fix at https://github.com/mozilla-b2g/gaia/pull/18987/files#diff-c277ab50102b302e9ec615d0f0c30e87R66

Comment 7

[[:AndreiH]]

Comment on attachment 8418000 [details] [review]
PR https://github.com/mozilla-b2g/gaia/pull/18987

Updated this, zac merge?

Comment 8

[Zac C (:zac)]

https://github.com/mozilla-b2g/gaia/commit/08971d90965084914d548b23a45b19657583d0df