Closed
Bug 1006475
Opened 10 years ago
Closed 10 years ago
remove unused gfxPlatformFontList::SetFixedPitch method
Categories
(Core :: Graphics: Text, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
|
2.32 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
We used to use this for certain fonts on pre-10.5 versions of OS X, but it's dead code now.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8417982 -
Flags: review?(jdaggett)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8417982 [details] [diff] [review] remove unused method gfxPlatformFontList::SetFixedPitch. Looks fine but we should also completely remove mFixedPitch from gfxFont.
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to John Daggett (:jtd) from comment #2) > Comment on attachment 8417982 [details] [diff] [review] > remove unused method gfxPlatformFontList::SetFixedPitch. > > Looks fine but we should also completely remove mFixedPitch from gfxFont. The mFixedPitch flag in gfxFontEntry is set by the Mac font-list code based on Cocoa font traits, and is checked when initializing font metrics; removing this is likely to change behavior for some fonts.
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8417982 [details] [diff] [review] remove unused method gfxPlatformFontList::SetFixedPitch. Ah, so this is just removing the unused method to set it.
Attachment #8417982 -
Flags: review?(jdaggett) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7643a5c899
Target Milestone: --- → mozilla32
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c7643a5c899
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•