1006481 - [SORA][GCF][STK] Some of LAUNCH BROWSER cases failed in TS131.124

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[xiaokang.chen]

Attachment: ts_131124v100100p.pdf

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:13.0) Gecko/20100101 Firefox/13.0.1 (Beta/Release)
Build ID: 20120615040358

Steps to reproduce:

just like TS131.124 shows in 27.22.4.26.1/4 27.22.4.26.2/1  27.22.4.26.2/2  27.22.4.26.2/3


Actual results:

these four case failed in gcf lab


Expected results:

27.22.4.26.1/4 27.22.4.26.2/1  27.22.4.26.2/2  27.22.4.26.2/3 test OK

Comment 1

[xiaokang.chen]

Dear Fernando,
I saw the code in gaia didn't support these cases. Can you have a look at this? Thanks a lot!

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Currently STK_CMD_LAUNCH_BROWSER only gets the "url" and "confirmMessage" options and launch the browser as you can check here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_worker.js#L135

Moreover, Gecko is sending confirmMessage, url and mode as you can see here:

http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozStkCommandEvent.webidl#233

Where MODE can be one of these three options:

http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozIccManager.webidl#17

So, currently Gaia is only ignoring the MODE option and uses the default behaviour in the system when a new URL should be opened.

If this is needed, it's a product decission to implement it (adding Noemi in CC to manage this)

Comment 3

[Noemí Freire (:noemi)]

As mentioned in comment 2, stk gaia code is not currently handling MODE parameter but using the default system behavior when launching the browser. Notice that it is the same behavior as in v1.1.
Adding this request to backlog to be properly prioritized by the product team for future releases.

Comment 4

[xiaokang.chen]

Dear Fernando,
Just ignore the mode parameters, I can get it from qualcomm's code.

What does "a browser session" means? I'm a little confused. 

Did the browser or system should add new APIs for these cases?

Thanks a lot!

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to xiaokang.chen from comment #4)
> Dear Fernando,
> Just ignore the mode parameters, I can get it from qualcomm's code.
> 
> What does "a browser session" means? I'm a little confused. 
> 
> Did the browser or system should add new APIs for these cases?
> 
> Thanks a lot!

Not sure if I understood your question correctly. Ask me again if this doesn't solve your concerns.

Currently in Gaia we open the browser from any app using what is called "activities" as you can see in this part of the code:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc.js#L369

      new MozActivity({
        name: 'view',
        data: { type: 'url', url: url }
      });

This MozActivity asks for any app which manages the activity "view" and with some data of "url" type. This activity can be manage by any app which registered it into his manifest (as browser does here): https://github.com/mozilla-b2g/gaia/blob/master/apps/browser/manifest.webapp#L53

  "activities": {
    "view": {
      "filters": {
        "type": "url",
        "url": {
          "required":true, "pattern":"https?:.{1,16384}", "patternFlags":"i"
        }
      }
    },

So when we launch the activity, if only the provided browser is installed into the device, this app will manage the operation. If you install a second app which can manage urls and registers this activity, the system will ask the user to select which app to use.

Finally, is the app decision who to manage this operation (the browser in this case), I mean, if he should create a new tab, new instance... is a browser decission no activity one.

Hopes this helps ;)

Comment 6

[xiaokang.chen]

Hi Fernando,
ts 31.124(v11.4.0) page 696 have this statement: "LAUNCH BROWSER, close the existing browser session and launch new browser session, connect to the default URL"

1 What the browser session means? A tab in the browser??

ts 31.124(v11.4.0) page 693 have this statement:"Expected Sequence 1.4 (LAUNCH BROWSER, only GPRS bearer specified and gateway/proxy identity, GPRS supported by USS)"

2 for this case the browser need a new API to use the parameters(bearer, gateway, proxy), right?

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to xiaokang.chen from comment #6)
> Hi Fernando,
> ts 31.124(v11.4.0) page 696 have this statement: "LAUNCH BROWSER, close the
> existing browser session and launch new browser session, connect to the
> default URL"
> 
> 1 What the browser session means? A tab in the browser??
> 
> ts 31.124(v11.4.0) page 693 have this statement:"Expected Sequence 1.4
> (LAUNCH BROWSER, only GPRS bearer specified and gateway/proxy identity, GPRS
> supported by USS)"
> 
> 2 for this case the browser need a new API to use the parameters(bearer,
> gateway, proxy), right?

Session: Application opened. In gaia only 1 session per app.
Tab: The browser app support multiple tabs (views) in which each one manages one webpage

When the browser receives the activity is handled here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/browser/js/browser.js#L1722

where you can see that a new tab is opened with the new URL

Comment 8

[xiaokang.chen]

Thanks a lot @ Fernando

Comment 9

[Wesly Huang (EPM)]

link all Fire C (codename: Sora) bugs to a meta one.

Comment 10

[BMO Automation]

Firefox OS is not being worked on