1006482 - [traceback] last_login is None for some users and it causes multiple errors

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Mathieu Pillard [:mat]]

I'm seeing the following error when resetting my password on dev:

Sentry URL:

http://sentry.dmz.phx1.mozilla.com/addons/addons-dev/group/19264/

Traceback:

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "session_csrf/__init__.py", line 138, in wrapper
    response = f(request, *args, **kw)
  File "django/utils/decorators.py", line 99, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "django/contrib/auth/views.py", line 158, in password_reset
    form.save(**opts)
  File "users/forms.py", line 101, in save
    self.base_save(**kw)
  File "users/forms.py", line 147, in base_save
    'token': token_generator.make_token(user),
  File "django/contrib/auth/tokens.py", line 18, in make_token
    return self._make_token_with_timestamp(user, self._num_days(self._today()))
  File "django/contrib/auth/tokens.py", line 59, in _make_token_with_timestamp
    login_timestamp = user.last_login.replace(microsecond=0, tzinfo=None)

AttributeError: 'NoneType' object has no attribute 'replace'


The issue is that last_login is None for my user. Which is weird, since https://github.com/mozilla/olympia/commit/7af2aa41a3ee95b02744faf281b5098edf7c641b should have taken care of that.

Comment 1

[Allen Short [:ashort]]

https://github.com/mozilla/olympia/commit/3f692b442fda

Comment 2

[Allen Short [:ashort]]

This is still occurring on production, the migration did not run properly:
http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/6355/
http://sentry.mktmon.services.phx1.mozilla.com/mkt/addonsmozillaorg/group/6353/

Comment 3

[Allen Short [:ashort]]

https://github.com/mozilla/olympia/commit/f2b827e17d5b2547696da109a7be0174fee79d75