1006489 - Scopes in the debugger don't always reexpand after stepping

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

So, 'window' and 'this' are never re-expanded, because performance. However, I found a few really weird cases in which the nodes get re-expanded only after hovering them!

STR:
1. Go to http://todomvc.com/architecture-examples/backbone/ and open debugger
2. Add breakpoint on line 31 of app-view.js
3. Reload and wait for breakpoint to be hit
4. Expand the middle function scope
5. Step in

The function scope should've been re-expanded. It's not. If you hover it, it gets re-expanded. Weird.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8418036 [details] [diff] [review]
v1

Review of attachment 8418036 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/test/browser_dbg_variables-view-reexpand-03.js
@@ +11,5 @@
> +let gBreakpoints, gSources, gVariables;
> +
> +function test() {
> +  // Debug test slaves are a bit slow at this test.
> +  requestLongerTimeout(4);

an inauspicious beginning...

@@ +35,5 @@
> +      .then(testVariablesExpand)
> +      .then(() => resumeDebuggerThenCloseAndFinish(gPanel))
> +      .then(null, aError => {
> +        ok(false, "Got an error: " + aError.message + "\n" + aError.stack);
> +      });

such .then().

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> Comment on attachment 8418036 [details] [diff] [review]
> v1
> 
> Review of attachment 8418036 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/debugger/test/browser_dbg_variables-view-reexpand-03.js
> @@ +11,5 @@
> > +let gBreakpoints, gSources, gVariables;
> > +
> > +function test() {
> > +  // Debug test slaves are a bit slow at this test.
> > +  requestLongerTimeout(4);
> 
> an inauspicious beginning...
> 

Copy paste leftover. I'll remove it.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f931138b37fc