Closed
Bug 1006490
Opened 10 years ago
Closed 10 years ago
Print button tooltip says "undefined" on Windows and Linux
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: dao, Assigned: mikedeboer)
References
Details
(Keywords: regression, Whiteboard: [bugday-20140514])
Attachments
(1 file)
2.57 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
This reverts changes made in bug 979479, which were wrong. Oops.
Attachment #8419275 -
Flags: review?(mconley)
Assignee | ||
Updated•10 years ago
|
Flags: firefox-backlog+
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8419275 [details] [diff] [review] Patch v1: revert changes made to the print button tooltip > #ifdef XP_MACOSX >- command="cmd_print" >+ command="cmd_print" tooltip="dynamic-shortcut-tooltip" > #else >- command="cmd_printPreview" >+ command="cmd_printPreview" tooltiptext="&printButton.tooltip;" > #endif Leave the lines with the command attribute alone, set tooltip/tooltiptext in a new line: #ifdef XP_MACOSX command="cmd_print" tooltip="dynamic-shortcut-tooltip" #else command="cmd_printPreview" tooltiptext="&printButton.tooltip;" #endif
Attachment #8419275 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks Dão! Pushed to fx-team, with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/ccdebc4f92c9
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ccdebc4f92c9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Comment 5•10 years ago
|
||
Hi, I was able to reproduce the issue on Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140506030204 CSet: 81651ad5e43c The issue is no longer present in: - latest nightly Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140514030203 CSet: 2f8af55d6e9a - latest aurora Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140514004005 CSet: fcbb78e6392e - latest beta Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140512231802 CSet: 25886b573924 Cheers, Francesca
Status: RESOLVED → VERIFIED
status-firefox30:
--- → verified
status-firefox31:
--- → verified
status-firefox32:
--- → verified
Whiteboard: [bugday-20140514]
You need to log in
before you can comment on or make changes to this bug.
Description
•