1006569 - [privacy] Add checkbox at sign-up

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Rebecca Billings [:rbillings]]

At signup, add a checkbox to request permission to use their email address to contact them (the Firefox feedback page (https://input.mozilla.org/en-US/feedback/) has a good example for a contact checkbox)

Comment 2

[Rebecca Billings [:rbillings]]

At signup, add a checkbox to request permission to use their email address to contact them.  "Check here to let us contact you to follow up on your feedback."

Add a checkbox to confirm assent to the privacy policy. "I’m okay with you handling this info as you explain in your privacy policy."  
* Link to privacy policy

Add message "Choose your username, using only lowercase letters and numbers. This will be used in your profile page address, so choose something other folks might recognize you as."

Add message "Your username may be displayed publicly with completed tasks."

Comment 3

[Bob Silverberg [:bsilverberg]]

I am +1 on all of these requirements, except for "Choose your username, using only lowercase letters and numbers." There should be no technical reason for that limitation and it seems very archaic to me. Why do you think we need to add that restriction?

Comment 4

[Rebecca Billings [:rbillings]]

I copied it from privacy suggestions. I'm down for:

Updated: Add message "Choose your username carefully. This will be used in your profile page address, so choose something other folks might recognize you as."

Comment 5

[Pankaj Malhotra (:bitgeeky)]

A Wireframe/Design Reference  will be helpful.

Comment 6

[Rebecca Billings [:rbillings]]

I will update this after the discussion regarding profile urls is set from bug 1018321

Comment 7

[Bob Silverberg [:bsilverberg]]

As this seems to be the master privacy bug now, please update this with the final wording that we want for the privacy notice. My understanding, from our meeting, is this:

1. We need a checkbox asking the user if we are allowed to contact them.
2. We need a notice explaining the privacy policy which explicitly states that their Profile Name (should we rename this to "Display Name") and a list of their completed tasks will be publicly visible.
3. We need to state that creating an account on the system automatically means accepting the privacy policy (i.e., there is no 2nd checkbox for "I accept the privacy policy").

Because of #3, we should also give existing users the option to delete their account if they do not want to accept the privacy policy. Perhaps the best way to do this would be via buttons on the form. The form could have 2 buttons: "I accept", which submits the form and either creates a new user or updates an existing user, "I do not accept", which would bring them back to the non-logged in page for a new user, and to a confirmation screen for an existing user, on which they would confirm that they do in fact want to delete their account.

This does seem a bit complicated, and will require extra code just for those cases (if any exist) where an existing user does not want to accept the privacy policy, but I'm not sure how else to address the issue.

I am looking for answers to this, and an update to the privacy notice text, as I plan on working on this as soon as the requirements are finalized.

Comment 8

[Bob Silverberg [:bsilverberg]]

I am releasing this for now to focus on bugs that could be implemented piecemeal.

Comment 9

[Rebecca Billings [:rbillings]]

Attachment: new account.png

Agreed upon text:
	◦	You are creating a profile that will include a public username and work history. You will begin to receive email communications from Mozilla once you have completed tasks. You may unsubscribe at any time by clicking the link at the bottom of these emails.
	◦	
	◦	[] I'm okay with you handling this info as you explain in Mozilla's Privacy Policy (http://mozilla.org/privacy/websites/)

- We don’t need a contact checkbox as it is within the Mozilla PP. Users will have option to opt out of emails when we get to implementing them.
- Displaying their name is also in the Mozilla PP - and called out in the text
- Existing users won’t be able to get past the Mozilla PP screen. If they do not accept the PP they cannot use the site. They also have the option of accepting, and then deleting their account/

Comment 10

[Bob Silverberg [:bsilverberg]]

bitgeeky is going to work on this when he has time between writing tests. I notice that there are a few bugs related to privacy and it's a bit difficult to see exactly what needs to be done in one place because of that. I'm going to look at all the bugs and merge them into this one, if that seems to make sense, so that bitgeeky can see and understand all of the requirements in one place.

Comment 12

[Bob Silverberg [:bsilverberg]]

From dup'd bug 1019799 (with some changes)

This is the new user account creation process:

1) Log in with Persona
2) User is sent to account creation page 
3) username/profile url creation outlined in bug 1018321
 - username will be created based on email address: remove domain, strip all non-alphanumeric characters, add a digit if not unique
4) textbox allowing user to change this generated username
 - need logic to prevent duplicate username when updated by a user
5) textbox allowing user to specify their Display Name
6) User must agree to Mozilla Privacy policy, presented as a required checkbox
 - if they do not agree delete their user record (or, alternatively, do not create a user record until they have agreed. That would be preferable, but not sure how doable that is), and then redirect them to the logged out home page.
7) Create account button

Comment 13

[Bob Silverberg [:bsilverberg]]

Rebecca, can you please review the above to make sure it is accurate, and if so update the wireframe to include the additional field?

Comment 14

[Rebecca Billings [:rbillings]]

What is the difference between 4 & 5? I thought there was one display name field which would simultaneously update the uernname & the url. Otherwise you have multiple name options.

Comment 15

[Rebecca Billings [:rbillings]]

>>should be "username" [someday we'll be able to edit comments!]

Comment 16

[Bob Silverberg [:bsilverberg]]

There are two names: 

1. The Display Name can be anything you want (e.g., Bob Silverberg), including spaces, special character's etc. It will be the name by which you are referred on the site (e.g., the heading on your profile, dashboard, etc.). This is what we currently have and call simply "Name" on the Edit Profile page.

2. The Username which also serves as the URL link to your profile (e.g., bsilverberg - url would be https://oneanddone.mozilla.org/en-US/profile/bsilverbeg (or something like that). This cannot contain spaces or special characters (otherwise it wouldn't work for a URL), which is why it is a separate field.

For the most part people will not change #2, but as we are going to initially generate it based on their email address, they might want to change it to make it more anonymous.

Does that clarify it/make sense?

Comment 17

[Rebecca Billings [:rbillings]]

That wasn't my original intention but it sounds good to me.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds ok to me too!

Comment 19

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/130

Added checkbox for privacy agreement.
This would force the new and existing users to sign privacy agreement before they can continue with the tasks.

Comment 20

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8441589 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/130

I added some comments specific to the code submitted in the pull request. I mentioned in there, and will mention here as well, that the PR submitted does not address this bug. There are a number of things requested in this bug that are not addressed. Please review the complete history of the bug and all of the comments to see what the requirements are.

Comment 21

[Bob Silverberg [:bsilverberg]]

:rbillings, could you please update the wireframe to include the new field as discussed above?

Comment 22

[Rebecca Billings [:rbillings]]

Attachment: updated new account

Updated with Display name and username/profile url fields

Comment 23

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

Everything works fine for me, all the tests pass and matches the given wireframe.

IMO the use case for deleting the email from database needs more thought and should be a separate bug.
So lets fix this one for now and Bob or I can take that up when this one is fixed.

Comment 24

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8445759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

Very close. Great work bitgeeky! Please flag me again for review when it's ready for another look.

Comment 25

[Pankaj Malhotra (:bitgeeky)]

Comment on attachment 8445759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

Made the suggested display changes. Please let me know if it looks good, so that I can squash the commits.

Comment 26

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8445759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

Almost there! I think these will be the last changes required.

Comment 27

[Pankaj Malhotra (:bitgeeky)]

Comment on attachment 8445759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

Made the changes. Please review.

Comment 28

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8445759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/135

This PR landed in https://github.com/mozilla/oneanddone/commit/fd291af29cb755a3e00517a86afef14814bc4962.

There is still work to do on the bug though, so not closing it.

Comment 29

[Bob Silverberg [:bsilverberg]]

Actually the other issues are covered by other bugs, so this can be closed. I'm not going to push it to staging yet as I'm having a problem deploying to staging currently.

Comment 30

[Bob Silverberg [:bsilverberg]]

Bitgeeky, I deployed this code to staging [1], but it doesn't seem to be working. When I go to the edit profile page for an existing user and save the username and check the box it doesn't seem to save the values. The message tells me it's saved, but when I go back in the checkbox still appears, unchecked, and if I try to reuse the same username for another user it does not warn me about a duplicate. So it seems like it's not saving to the database for some reason.

Can you please look into this and see if you can figure out why that might be happening?

[1] https://oneanddone.paas.allizom.org

Comment 31

[Bob Silverberg [:bsilverberg]]

I just tested it again locally and it's not working locally either, so somehow a bug has been introduced since I last tested it. Please treat this as a very high priority item and try to figure out how to get this working again.

Comment 32

[Bob Silverberg [:bsilverberg]]

I knew this really needed to be fixed ASAP so I found the problem and fixed it. It's now working on dev and staging.

Comment 33

[Rebecca Billings [:rbillings]]

Verified new users see PP, checkbox and it acts correctly in creating new profiles- particularly that it won't let you take a task until you fill out the form and save.