Closed
Bug 1006628
Opened 10 years ago
Closed 10 years ago
[Home2] Follow instantiable pattern standards
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file)
In bug 1006526 we gave zoom.js some much needed refactoring, but unfortunately the lines have started to blur regarding instantiation patterns. I think we should draw a hard line at: CamelCasedNames = classes camelBackedNames = instantiated objects We also removed app namespacing, but this is probably ok as layout is such a commonly accessed object. I would recommend either having an app.layout or a window.layout object. (We are currently using window.Layout).
|
Assignee | |
Comment 1•10 years ago
|
||
Hey Cristian - what do you think about following this instantiation pattern? Thanks!
Attachment #8418140 -
Flags: review?(crdlc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8418140 [details] [review] Github pull request LGTM and I am ok with your change and pattern, perfect!
Attachment #8418140 -
Flags: review?(crdlc) → review+
|
|
||
Comment 3•10 years ago
|
||
Merged in master: https://github.com/mozilla-b2g/gaia/commit/6df4663cad3c9f369dc89e2310991da6ad0c25aa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•