1006692 - Remove nsScriptSecurityManager::SubjectIsPrivileged and AccessCheck::IsCallerChrome

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

With bug 997987, these can now just go through nsContentUtils::IsCallerChrome().

Comment 1

[Julien Levesy]

Attachment: Patchv1

Here's a first attempt.
It builds, but I didn't tested it. Actually I don't know which test suite I have to run to valitate this patch.
Thanks for review :-) !

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8425053 [details] [diff] [review]
Patchv1

Thanks for the patch! In the future, you should set the 'review?' flag to someone appropriate to make sure that the patch doesn't get lost. I'll look at it now. :-)

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8425053 [details] [diff] [review]
Patchv1

Review of attachment 8425053 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! I think a try push with the following parameters should suffice:

try: -b do -p linux64 -u all -t none

Let me know if you need someone to push this to try for you. :-)

Comment 4

[Julien Levesy]

Oops, I didn't see your answer.
Sorry about that. 
Actually I don't think I have the rights to make a try push.
I'm a quite new contributor :) 
So, could you push this for me ? 
Thanks !

Comment 5

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=15f92b29fa63

Comment 6

[Carsten Book [:Tomcat]]

checkedin - Julien, welcome and thanks for contributing to mozilla!
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc4c4e5fe01d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc4c4e5fe01d