1006739 - [tarako] build with --disable-webrtc

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[[:fabrice] Fabrice Desré]

Product decision, saving a bit of resources.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: gecko patch

We need that to build.

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: gonk-misc patch

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8418243 [details] [diff] [review]
gonk-misc patch

Review of attachment 8418243 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure the right way to do that.  Also, have you done a clobber build?

::: default-gecko-config
@@ +85,5 @@
>  if [ "${MOZILLA_MLS_KEY_FILE:-0}" != 0 ]; then
>  ac_add_options --with-mozilla-api-keyfile=${MOZILLA_MLS_KEY_FILE}
>  fi
> +
> +ac_add_options --disable-webrtc

This should conditional on Tarako....

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8418242 [details] [diff] [review]
gecko patch

Review of attachment 8418242 [details] [diff] [review]:
-----------------------------------------------------------------

I'll give this patch the benefit of the doubt, though I still don't know what a synthpico is ;-)

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Randell Jesup [:jesup] from comment #3)
> Comment on attachment 8418243 [details] [diff] [review]
> gonk-misc patch
> 
> Review of attachment 8418243 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not sure the right way to do that.  Also, have you done a clobber build?
> 
> ::: default-gecko-config
> @@ +85,5 @@
> >  if [ "${MOZILLA_MLS_KEY_FILE:-0}" != 0 ]; then
> >  ac_add_options --with-mozilla-api-keyfile=${MOZILLA_MLS_KEY_FILE}
> >  fi
> > +
> > +ac_add_options --disable-webrtc
> 
> This should conditional on Tarako....

This will land only on the 1.3t branch

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8418243 [details] [diff] [review]
gonk-misc patch

Review of attachment 8418243 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently there's no way to have a conditional on Tarako..... :-( :-(

Comment 7

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/fc2577e339b9

Comment 8

[[:fabrice] Fabrice Desré]

gonk-misc 1.3t:
3af273dc1d9a97bb8ce4dff92201b0fe06c6c12d

Comment 9

[James Zhang (Spreadtrum)]

Thank you for tarako only workaround.

Comment 10

[[:fabrice] Fabrice Desré]

Followup to disable webrtc tests:  https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/5c33164eb0ca

Comment 11

[[:fabrice] Fabrice Desré]

Not quite right, backed out:  https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/1d997ccbf79c

Comment 12

[StevenLee[:slee]]

Hi Fabrice,

What's error do you encounter? I sent a patch to Wayne for disabling webrtc on tarako and it works. Is it " error: undefined reference to 'synthpico_NSModule'" ?

Comment 13

[StevenLee[:slee]]

Attachment: disable pico module in configure

Comment 14

[[:fabrice] Fabrice Desré]

(In reply to StevenLee[:slee] from comment #12)
> Hi Fabrice,
> 
> What's error do you encounter? I sent a patch to Wayne for disabling webrtc
> on tarako and it works. Is it " error: undefined reference to
> 'synthpico_NSModule'" ?

No, I just backed out the patch to not get orange tests on tbpl. See https://tbpl.mozilla.org/?tree=Mozilla-B2g28-v1.3t where M6 and M7 are perma-orange.

Comment 15

[[:fabrice] Fabrice Desré]

relanded the followup at https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/cfc406e6ec85 since try is green for M6/M7 (https://tbpl.mozilla.org/?tree=Try&rev=a6826ff22c74)