1006765 - Dialogs shown while Windows lock screen is up don't paint correctly

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

If Firefox displays a dialog box during the time that the Windows lock screen is up, the dialog's content is not painted once the user has entered their password and dismissed the lock screen. The dialog's border is visible but the content area is transparent. It isn't painted properly until the mouse is moved or clicked in the dialog's client area.

I noticed this with both the slow script dialog and (more commonly) the upgrade dialog box that prompts the user to restart now or restart later.

STR (I'm sure there is a more expedient way to reproduce this):
1. Run Nightly and have it as the foreground window.
2. Put the computer to sleep.
3. Put yourself to sleep.
4. In the morning, wake up your computer and log in.
5. Observe the restart now/later dialog box is nothing but a border.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: show_update_dlg.js

Here are better STR:

1. Open a privileged console
2. Run the attached script in the console.
3. Before the script's timeout triggers (5 seconds in the attached version), Minimize Firefox and lock your screen (Win+L keyboard shortcut)
4. Wait for the timeout to elapse.
5. Unlock your screen.
6. Examine the dialog.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Ensure that Win32 widget handles WM_WTSSESSION_CHANGE

This patch adds support for WM_WTSSESSION_CHANGE. For this bug we just invalidate when we see a notification that our session has been reactivated.

This message could also be useful in the future for power saving purposes (since we could detect when our session is not in use).

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8420684 [details] [diff] [review]
Ensure that Win32 widget handles WM_WTSSESSION_CHANGE

Review of attachment 8420684 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ +606,5 @@
>    }
>  
>    SubclassWindow(TRUE);
>  
> +  // We need to register to receive terminal services notification messages.

nit - the question of why we need to register should be addressed in this comment as well.

@@ +607,5 @@
>  
>    SubclassWindow(TRUE);
>  
> +  // We need to register to receive terminal services notification messages.
> +  ::WTSRegisterSessionNotification(mWnd, NOTIFY_FOR_THIS_SESSION);

Lets check the result here and assert if the call fails.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Ensure that Win32 widget handles WM_WTSSESSION_CHANGE

Addressed nits, carrying forward r+

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://tbpl.mozilla.org/?tree=Try&rev=3e55c41a9ee5
https://hg.mozilla.org/integration/mozilla-inbound/rev/eae28132e647

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eae28132e647