consider adding e10s window.open()/close() test

NEW
Unassigned

Status

()

defect
P5
normal
5 years ago
2 months ago

People

(Reporter: bkelly, Unassigned)

Tracking

(Blocks 1 bug)

30 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+)

Details

As discussed in bug 998504, one of our b2g partners has a handy little test app that does nothing but call window.open()/close() in a child process.  This recently caught some memory leaks in both DOM and gfx.  I believe it has caught problems in the past as well.

Now that we have e10s mochitests running, lets see if its possible to create a similar test in tbpl.

The partner test app can be found in bug 964386 attachment 8366455 [details].
And I'd like to try to do this now while its fresh in my mind.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Looking at bug 989501 and bug 1001707 I wonder if we're far enough along with e10s testing yet to do this.  If its doable in a couple of days work I'd still like to try to do it.  Bill, what do you think?
Flags: needinfo?(wmccloskey)
I'm not sure exactly what you're proposing. We don't normally run long-running tests on tinderbox, and we also don't really have a way of checking memory usage of a test.

window.open and window.close work in e10s. Even if they didn't, though, you could still run the test on b2g, which uses a different way of opening and closing windows.
Flags: needinfo?(wmccloskey)
It is quite simple to get CC log to JS as a graph and go through it and check that it doesn't
contain anything suspicious. That is what browser-chrome tests, at least, do.
(In reply to Bill McCloskey (:billm) from comment #3)
> I'm not sure exactly what you're proposing. We don't normally run
> long-running tests on tinderbox, and we also don't really have a way of
> checking memory usage of a test.

Sorry, I wasn't particularly clear.  I want to run window.open() and window.close() from a child process a few times.  The test app I am working from uses a b2g "attention" window, but not sure thats necessary.  I don't think we would need to run this for a long time to catch a problem.

I was hoping our current leak detection tools would then find any leaked objects.  Or perhaps I would have to write something to inspect the CC logs.

> window.open and window.close work in e10s. Even if they didn't, though, you
> could still run the test on b2g, which uses a different way of opening and
> closing windows.

Yea, maybe it needs to run in the b2g emulator tests.  I guess I was hoping to write something that would catch any problems in both desktop and b2g, but maybe thats more trouble than its worth.

To be honest, I don't really know much about the different types of tests we run, so maybe I'm not even asking the right questions.  Just seems like we should try to automate this test app in some way since its found problems with the platform on multiple occasions.
In IRC Gregor recommended doing this in a mochitest running in b2g-desktop -oop.
I still think this would be a good idea, but I've missed my window of opportunity in terms of time availability.  I'm not going to get to this any time soon.
Assignee: bkelly → nobody
Status: ASSIGNED → NEW
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.