Closed Bug 1006869 Opened 10 years ago Closed 10 years ago

Checkbox menu items in the app menu not displaying their checkmarks.

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 32.0

People

(Reporter: jsbruner, Assigned: jsbruner)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch. (obsolete) — Splinter Review
There's a "#appmenu-popup menuitem:not([type="radio"]):not(.folderMenuItem) > .menu-iconic-left { display: none; }" rule that is making it so checkmarks aren't showing up in the app menu. We should add a :not([type="checkbox"]) as well.
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Attachment #8418400 - Flags: review?(richard.marti)
Blocks: 978592
Comment on attachment 8418400 [details] [diff] [review]
Patch.

Review of attachment 8418400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: mail/themes/osx/mail/primaryToolbar.css
@@ +931,4 @@
>  }
>  
>  .splitmenu-menuitem > .menu-iconic-left,
> +#appmenu-popup 

Nit: trailing whitespace.
Attachment #8418400 - Flags: review?(richard.marti) → review+
Attached patch Patch.Splinter Review
Attachment #8418400 - Attachment is obsolete: true
Attachment #8419578 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b0b68d22439b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.