1006919 - [Gallery] Remove work around to generate and pass file backed blob for pick activity inside gallery.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Punam Dahiya [:pdahiya]]

As fix of Bug 975599, we used a workaround to pass a file backed blob in pendingPick.postResult. Workaround saves the blob to a temporary file in device storage and then reads that file back and passes that to endPick in gallery.js.

With the fix of bug 982779, we can remove convertToFileBackedBlob function and use cropped region memory-backed blob directly.

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of bug 1006919

Hi David,

I have removed the workaround for bug 975599 from gallery.js. Please review.

Thanks

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8418970 [details] [review]
PR with fix of bug 1006919

The patch looks good.

Please verify that landing this patch does not bring bug 975599 back.

We'll need to uplift this to 1.4 as well, since the gecko bug was fixed there.

Note that removing this workaround means that if the user has temporary files stored in .gallery/tmp/ when they upgrade from 1.3 or 1.3T to a newer release, those files will never be deleted.  I'm okay with that, though. It seems simpler to live with it than to take the risk of adding the extra code needed to detect and delete those stranded files.

Comment 3

[David Flanagan [:djf]]

Nominating this for 1.4 since it is a pretty huge workaround that is no longer needed on the v1.4 branch.

Comment 4

[David Flanagan [:djf]]

Punam: could you also check on the patch that landed in bug 949941?  I think that is something we want to keep (because it is more efficient to pass the file that we're saving anyway). But just want to make sure that there are not workarounds there that we could also remove as part of this patch.

Comment 5

[Punam Dahiya [:pdahiya]]

Verified landing this patch does not bring bug 975599 back, patch landed on  master
https://github.com/mozilla-b2g/gaia/commit/44fed8d50581dfc3b61386c77531aeba7f6c5f38

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to David Flanagan [:djf] from comment #4)
> Punam: could you also check on the patch that landed in bug 949941?  I think
> that is something we want to keep (because it is more efficient to pass the
> file that we're saving anyway). But just want to make sure that there are
> not workarounds there that we could also remove as part of this patch.

I walked through 949941 patch, and we are saving files even before 949941 patch when memory backed blobs were used. We are doing refetchImage as an extra step to read file backed blob as addNamed does not give us File Handle but this is not a workaround and IMO should be ok considering we are passing the file that we are saving. 
https://github.com/mozilla-b2g/gaia/pull/17136/files#diff-0eef4fb5c22c93bb9dbce7eb56edf5a6R68

Thanks

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/1c1ca27cfffb5edf690e6d712f2af3ac64488e46