Closed Bug 1006956 Opened 6 years ago Closed 6 years ago

Don't enable sccache on PGO builds

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
B2G C4 (2jan on)

People

(Reporter: philor, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

<philor> glandium:  what does https://tbpl.mozilla.org/php/getParsedLog.php?id=38897992&tree=B2g-Inbound mean?
...
<glandium> philor: also, it means sccache is enabled on pgo builds, and i'm not comfortable with that yet
<glandium> philor: so please file another bug about that too
Attachment #8419135 - Flags: review?(mshal)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8419135 [details] [diff] [review]
Disable sccache on non-try PGO builds

>+        if test -z "$MOZ_PGO"; then

Are you sure we can actually access MOZ_PGO here? I tried to add this to my mozconfig:

if test -z "$MOZ_PGO"; then
        mk_add_options "export MYPGO=1"
else
        mk_add_options "export MYPGO=2"
fi

Both 'make -f client.mk configure' and 'make -f client.mk configure MOZ_PGO=1' go through the first case. The second case can be triggered by using the environment instead ('MOZ_PGO=1 make -f client.mk configure'), but according to the build log we pass it in as a make argument, so I don't think this will work.
Attachment #8419135 - Flags: review?(mshal) → review-
You're right. This is about the only way i can think of (and that works) to do this.
Attachment #8421444 - Flags: review?(mshal)
Attachment #8419135 - Attachment is obsolete: true
Attachment #8421444 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/5c6cf0b0f31e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2G C4 (2jan on)
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.