1006973 - Fix bustage in casting pageaction

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fix-pageaction v0.1

I screwed up when refactoring code during the review process in bug 1001280. Grrr.

This patch fixes a JS error and allows the pageaction to work.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8418519 [details] [diff] [review]
fix-pageaction v0.1

Wes is PTO the next two days

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8418519 [details] [diff] [review]
fix-pageaction v0.1

Review of attachment 8418519 [details] [diff] [review]:
-----------------------------------------------------------------

I'm still alive till Thursday!

::: mobile/android/chrome/content/CastingApps.js
@@ +89,5 @@
>        case "ended": {
>          let video = aEvent.target;
>          if (video instanceof HTMLVideoElement) {
> +          // If playing, send the <video>, but if ended we send nothing to shutdown the pageaction
> +          this._updatePageActionForVideo(aEvent.type == "playing" ? video : null);

===

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e37c6d3bc781

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e37c6d3bc781

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8418519 [details] [diff] [review]
fix-pageaction v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1001280 had a refactor bug
User impact if declined: feature does not work
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, and proven to fix the issue
String or IDL/UUID changes made by this patch: none

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/374edcad4574